Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastMember.Signed increases AssemblyVersion for minor updates #76

Open
danstur opened this issue Jul 4, 2019 · 1 comment
Open

FastMember.Signed increases AssemblyVersion for minor updates #76

danstur opened this issue Jul 4, 2019 · 1 comment

Comments

@danstur
Copy link

danstur commented Jul 4, 2019

The signed package currently has an AssemblyVersion of 1.5.0. This breaks semantic versioning for people using the package: If someone requires version 1.4.0, 1.5.0 should work as a drop-in replacement. With the current configuration this requires assembly redirects which work but are annoying.

If instead the AssemblyVersion is only increased when breaking changes are introduced, we get what I would consider optimal behavior: You get a warning if you try to use incompatible versions, which you can explicitly ignore with binding redirects. For minor versions if two NuGet packages require different versions, NuGet resolves the higher version which is then installed.

Would a PR be accepted that changes this behavior to explicitly setting the AssemblyVersion in the csproj with the intent to only increasing it to 2.0.0 when/if breaking changes are ever introduced?

@mgravell
Copy link
Owner

mgravell commented Jul 4, 2019

Would a PR be accepted that changes this behavior to explicitly setting the AssemblyVersion in the csproj with the intent to only increasing it to 2.0.0 when/if breaking changes are ever introduced?

short answer: yes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants