$logger->notice() should be resolved to WP_CLI::log instead of WP_CLI::warning

[hirasso]

Hi @markheydon, thanks for this little package! This is not really a bug, but rather a design question.

Regarding to the documentation of Monolog:

NOTICE (250): Normal but significant events.

This should not trigger a WP_CLI::warning, but rather just a simple WP_CLI::log:

$logger->notice('Something normal but significant happened');

What do you think? Happy to create a PR if you agree.

[markheydon]

Very kind of you to say @hirasso. Honestly, when I first wrote it I did deliberate a bit on the mappings of the 'levels' so not surprised I didn't quite get it how some might want it to work.

I've no problem in theory changing this but wouldn't want to break anything that might be out there already, which probably isn't that much in all honesty.

I'm tied up today but will take a look through my notes tomorrow and see why I decided to pick that mapping in the first place. Have you got the link to the documentation you quoted?

[hirasso]

Here is the link to the log level documentation:

https://seldaek.github.io/monolog/doc/01-usage.html#log-levels

[hirasso]

Any news on this?

[markheydon]

@hirasso Over 12 months since last looked at his, honestly not completely sure why I managed to stall this, so sorry about that. Did this stall some project or other you were working on? I hope not! I probably would have at least looked at a PR in all honestly, not sure why I didn't just say that at the time either.

Having just re-read the link you sent me, I'd probably agree with you (if I didn't at the time already in fact).

I need to update the code for latest versions etc. anyway so will probably do this as part of the same.

[hirasso]

Hey @markheydon , no this wasn't a bigger issue for me. It would still be very nice to get this "fixed" in the next release. Good to see you haven't forgotten about it 🙂

[markheydon]

Forgot? No not all! Just migrated to Zenhub though as was using Azure DevOps for works stuff thus personal stuff didn't get much of a look in 😜.