Adding localization

[sebastianbinder]

Might be a good idea to prepare this app for localization. No idea how this works on code level, but glad to help out with a German translation as soon as it becomes possible on code level.

[FluffyDev2019]

I would gladly help out with a Swedish (Svensk) trasnaltion.

[mhdhejazi]

Great. I'll prepare the project for localization.

---

UPDATE:

To make it easier to update the translations and contribute, I created a project on poeditor.com and imported all existing translations. From now on, you can easily update the translations from poeditor.com website. No need for manual updates and pull requests anymore.

The project link: https://poeditor.com/join/project/UTZyE0GKiT

[mhdhejazi]

I prepared the project and added two localization files for:

1. German:
   https://github.com/MhdHejazi/CoronaTracker/blob/master/Corona/Localization/de.lproj/Localizable.strings
2. Swedish:
   https://github.com/MhdHejazi/CoronaTracker/blob/master/Corona/Localization/sv.lproj/Localizable.strings

The strings need to be translated.

[sebastianbinder]

Created a PR #27

[FluffyDev2019]

Created a PR #28

[mhdhejazi]

Thank you guys for the great work!

BTW, I didn't add country names to the localization files because they're part of the data and may change at any time (happened twice before). Do you think we should also translate them?

[FluffyDev2019]

Of course, just point me were to do that.
Sweden = Sverige
Swedish = Svenska

[Ale111]

Hi, I would glad to help out with Italian translation. Can you add the italian localization?

[mhdhejazi]

Sure. Here you go:
https://github.com/MhdHejazi/CoronaTracker/blob/master/Corona/Localization/it.lproj/Localizable.strings

[sebastianbinder]

Regarding country names: Isn’t there a way to use the Apple Map Kit for that? I think there should be translations somewhere already so you could try to solve this programmatically first. Kinda source says „Germany“ -> query Maps -> getting a country object -> output name in device language. Don’t know if this is possible but might be worth a try.

[mhdhejazi]

There is a way to translate country names in iOS. The problem is the non-standard names used in the data (e.g. "Korea, South" vs. "South Korea"). See the country names here.

Anyway, I think I'll try to get the translated names from iOS, and when that fails, use the original name. If the result isn't good enough we can work on normalizing the country names.

[mhdhejazi]

I did that. Check the app and let me know how it's looking.

I also translated the month names and rotated the country names in the charts to make sure they don't overlap with each other. If you find any other problem let me know, please.

[ppamorim]

@mhdhejazi Why the italian translation has the values in english?

https://github.com/MhdHejazi/CoronaTracker/blob/master/Corona/Localization/it.lproj/Localizable.strings

[sebastianbinder]

If you read above the Italian file still needs translation 🤷🏼‍♂️

[ppamorim]

@sebastianbinder So what's the point to commit the file and setup? Also this should be a PR.

[sebastianbinder]

I‘m not speaking Italian. Need to wait for @Ale111 to translate the file. If it’s important for you feel free to translate it yourself.

[ppamorim]

So @Ale111 should be the person to open the PR like a did in my translation to Portuguese. #29

[mhdhejazi]

Yes, check the replies from above. I added the seed files to simplify the process of translation. With the file added, you don't need Xcode anymore, and you can even do everything from the browser.

[mhdhejazi]

I collected all the country names from the data source in one file and added the ISO code for each country name.

So all country names are now auto-translated.

[ppamorim]

@mhdhejazi Instead of adding wrongly set up translation and fix after, we should add the translations without linking it into the project and a developer with access to Xcode should setup what is needed to embed it in the project.

[mhdhejazi]

I understand where you're coming from and agree with you in principle, but I prefer to keep things as simple as possible for those willing to contribute.

[mhdhejazi]

We have two new strings to be translated:

CoronaTracker/Corona/Localization/Base.lproj/Localizable.strings

Line 16 in 76844e3

"chart.delta" = "Daily New Cases";

CoronaTracker/Corona/Localization/Base.lproj/Localizable.strings

Line 21 in 3d8863f

"data.source" = "Source: %@";

P.S. The translations can be updated from the web browser if you wish. Just find the proper file here and press the edit button.

[dev-sora]

If you still don't have any 'Japanese' translator, I'll be the one.

[mhdhejazi]

@dev-sora Sure! And thank you in advance.

[dev-sora]

@mhdhejazi So could you add Japanese directory under Corona/Localization? Or is it my task?

[mhdhejazi]

Sure. Here you go: https://github.com/mhdhejazi/CoronaTracker/blob/master/Corona/Localization/ja.lproj/Localizable.strings

[dev-sora]

Hi. I couldn't push my work on 'master'. Could you add me as a contributor, or another way?

[mhdhejazi]

You need to work on your fork and then create a pull request. Or you can update the file directly in the browser by pressing the edit button, and GitHub will create a fork and a pull request for you when you're done.

[dev-sora]

Thank you for your kind reply!! I've already done my work.

[hdatteln]

Submitted a PR with Dutch translations: #78

[mhdhejazi]

Merged. Thank you!

[hussamzain]

Submitted the Arabic language, #86

[mhdhejazi]

Merged. Thank you!

[comradekingu]

I would suggest adding this to the libre software https://weblate.org/hosting/ to make it easier to contribute.(Gratis for libre software as you can see.) Noticed some languages using triple-dot ... instead of ellipis … and various stings missing, which would become more apparent if displayed as "not translated" on the platform.

[surak]

Fails to compile, saying that localization is in an invalid format. Go figure. Latest version of everything.

[mhdhejazi]

@comradekingu Yeah. I think we have to do that.
@surak I merged a fix for the German translation. Try again now.

[nikotidar]

Hi there, I'm from Indonesia. I'm trying to contribute to this app and I'm add Indonesian translation to this app. Maybe you can check this? #92

Thanks before 😃

[mhdhejazi]

@nikotidar Merged. Thank you for taking the time to contribute.

[nikotidar]

@nikotidar Merged. Thank you for taking the time to contribute.

You're welcome 😃

[comradekingu]

#88
Norwegian Bokmål by "Allan Nordhøy" e-mail in my profile. Only use @comradekingu for communication here.

[mhdhejazi]

@comradekingu I used the mentions for all contributors as they provide more info. One can see your user card (which contains far more than your name) when they hover over your mention, and they can also open your page and see even more. And I already added the full names and GitHub pages to all translation files.
But if you don't like how your name is mentioned, please feel free to change it and create a PR.
Thank you for your contribution again.

[mhdhejazi]

I figured that GitHub doesn't show a user card for mentions in the readme file, so I added the full names for everybody with a link to their profile.

[mhdhejazi]

To make it easier to update the translations and contribute, I created a project on poeditor.com and imported all existing translations. From now on, you can easily update the translations from poeditor.com website. No need for manual updates and pull requests anymore.

The project link: https://poeditor.com/join/project/UTZyE0GKiT

[KovalevArtem]

Not sure if these lines require translation

[mhdhejazi]

Just reload the page. The words are added.