fix: make prefetch lazy again #229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By avoiding reseting the i for loop
Otherwise an error would be logged in routes.Compile
This was referenced Aug 6, 2024
|
Superseded by #208 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes layer4 to again only read lazily from the connection during matching.
With this tcp proxy configs for protocols where the server speaks first work again.
I have also added some example configs for these cases to #209 "matcher without io" & "server speaks first".
Closes #212, #228
@mholt This is based on #210 since I wanted to test it together with all the other fixes & tests. I also think this version of the matching loop is even simpler because we do not need a labeled jump or a "global"
routeIdxanymore.