-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Too many open files #58
Comments
Try |
Still getting the same error. @mhutch. |
This is an issue in Mono.Addins, see mono/mono-addins#110 for another workaround You can also modify the file handle limit on a more permanent basis, see https://gist.github.com/tombigel/d503800a282fcadbee14b537735d202c |
@mhutch @jzeferino Any updates for this issue? |
No, but there is a workaround linked above |
I didn't tested the permanent way but the |
@jzeferino @mhutch
It is not cool. |
@slluis is there any way we can suppress all the "invalid assembly" errors? |
@mhutch Any updates? |
The unwritten contract of AddinFileSystemExtension.GetReflectorForFile expects it to cache the Reflector, and the base implementation does that: https://github.com/mono/mono-addins/blob/e84472dcd17b61a904538e1cc2e19f4b064c7068/Mono.Addins/Mono.Addins.Database/AddinFileSystemExtension.cs#L170 AddinScanner.Dispose() then calls database.FileSystem.CleanupReflector ();: https://github.com/mono/mono-addins/blob/e84472dcd17b61a904538e1cc2e19f4b064c7068/Mono.Addins/Mono.Addins.Database/AddinScanner.cs#L58 This change does two things: 1. Dispose of the Registry after the ResolveMonoDevelopAddins task is done, which in turn disposes the Cecil Reflector 2. Removes the overridden GetReflectorForFile from CecilReflectorExtension since that is equivalent to the base implementation but without the caching. The base implementation does proper caching. The fix has many benefits, such as: 1. Not allocating many file handles 2. Cleanup file handles after use 3. Improve build perf from 3.4 to 2.1 seconds on a solution with two addin projects Fixes mhutch#55 Fixes mhutch#58
I'm getting a build error saying:
Im running on OSX and the project is this. You could also have some information in the CI server with the same problem.
Can you give me some hint on this?
The text was updated successfully, but these errors were encountered: