Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Required Changes for the MarketPlace Contract #46

Closed
ro61zzy opened this issue Oct 14, 2024 · 2 comments
Closed

Required Changes for the MarketPlace Contract #46

ro61zzy opened this issue Oct 14, 2024 · 2 comments
Assignees
@Tchisom17 @AbolareRoheemah @ro61zzy @RahmanC @DonGuillotine @michojekunle @Micjohn01 @yusufroqib @ceasermikes002

Comments

@ro61zzy
Copy link
Collaborator

ro61zzy commented Oct 14, 2024

Description:

File: MarketPlace.sol

Points to address:

  1. Interaction with SellerVerification and CarVerification contracts:

    • Important: add a check to ensure that the seller attempting to list a car is verified. The verification process should also include checking the Vehicle Identification Number (VIN) and any relevant details to confirm the vehicle is authentic and verified.

    Suggested Action: Implement validation to ensure that both the seller and the car pass verification before proceeding with any listings.

  2. Auction Contract Interaction:

    • How does this contract interact with the auction contract? At what point does the auctioning process come into play?

    @Tchisom17, could you please comment on this

  3. Compatibility with the NFT Contract:

    • Will this contract integrate seamlessly with the existing NFT contract? NFT contract easily interface with this marketplace.

    @DonGuillotine,
@ro61zzy ro61zzy self-assigned this Oct 14, 2024
@michojekunle michojekunle pinned this issue Oct 14, 2024
@ro61zzy ro61zzy mentioned this issue Oct 14, 2024
Merged
@DonGuillotine
Copy link
Collaborator

Description:

File: MarketPlace.sol

Points to address:

  1. Interaction with SellerVerification and CarVerification contracts:

    • Important: add a check to ensure that the seller attempting to list a car is verified. The verification process should also include checking the Vehicle Identification Number (VIN) and any relevant details to confirm the vehicle is authentic and verified.

    Suggested Action: Implement validation to ensure that both the seller and the car pass verification before proceeding with any listings.

  2. Auction Contract Interaction:

    • How does this contract interact with the auction contract? At what point does the auctioning process come into play?

    @Tchisom17, could you please comment on this

  3. Compatibility with the NFT Contract:

    • Will this contract integrate seamlessly with the existing NFT contract? NFT contract easily interface with this marketplace.

    @DonGuillotine,

All done, I updated the contract -> https://github.com/michojekunle/Vintage-Car-Marketplace/pull/51/files

@michojekunle
Copy link
Owner

Closing Issue:

Issue fixed at PR #51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Tchisom17 Tchisom17

@AbolareRoheemah AbolareRoheemah

@ro61zzy ro61zzy

@RahmanC RahmanC

@DonGuillotine DonGuillotine

@michojekunle michojekunle

@Micjohn01 Micjohn01

@yusufroqib yusufroqib

@ceasermikes002 ceasermikes002

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
9 participants
@Tchisom17 @AbolareRoheemah @ro61zzy @RahmanC @DonGuillotine @michojekunle @Micjohn01 @yusufroqib @ceasermikes002