Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v0.20.0: recipes/base_watcher doesn't handle asyncio.CancelledError exception properly #44

Open
aaronps opened this issue Jan 13, 2020 · 1 comment
Open

v0.20.0: recipes/base_watcher doesn't handle asyncio.CancelledError exception properly #44

aaronps opened this issue Jan 13, 2020 · 1 comment

Comments

@aaronps
Copy link

aaronps commented Jan 13, 2020

And so you might get an ugly log saying: "Not handled in watch loop", maybe cleanup and break or raise would be better.
@cybergrind
Copy link
Member

@aaronps yep, you're totally right here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cybergrind @aaronps