Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal Server Error parsing HTML snippet without Base URL #9

Open
gRegorLove opened this issue Sep 14, 2023 · 1 comment · May be fixed by #10
Open

Internal Server Error parsing HTML snippet without Base URL #9

gRegorLove opened this issue Sep 14, 2023 · 1 comment · May be fixed by #10

Comments

@gRegorLove
Copy link
Member

I tested after #2 was resolved (🎉 thanks!) by entering the HTML snippet and no Base URL:

<div class="h-entry">
  <h1 class="p-name">Test Post</h1>
  <div class="e-content"><p>Lorem ipsum</p></div>
</div>

I got "Internal Server Error"

I tried again, entering the Base URL https://example.com and it worked.

It should probably support parsing without a base URL like the other parser sites, or at least require the Base URL field to avoid the error.

@aimee-gm aimee-gm linked a pull request Sep 14, 2023 that will close this issue
@aimee-gm
Copy link
Member

@gRegorLove I've opted to make Base URL a required field at the moment, as it's required by microformats-parser.

I've also added some handling for any errors microformats-parser throws during execution, rather than swallowing them up as `Internal Server Error, so if anything like this happens, the user has an indication as to how to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants