-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Download binary from custom mirror, e.g. S3 #1
Comments
Hello, can you give me a valid S3 URL for testing? 🙂 |
@Kikobeats Here you go :) |
shipped at just you need to setup
or
Also, I added some details about environment variables into the documentation: https://github.com/microlinkhq/youtube-dl-exec/blob/master/README.md#environment-variables |
why cant we just append .exe based on the detected os? This now requires setting up environment variables based on the OS before installing the package. 😕 |
it auto-detects the platform and add https://github.com/microlinkhq/youtube-dl-exec/blob/master/src/constants.js#L21 |
Currently, it seems like the binary can only be downloaded from S3. I created przemyslawpluta/node-youtube-dl#351 on node-youtube-dl
Since this package supersedes
node-youtube-dl
I think there should be an option for a custom mirror.A possible implementation could use the
YOUTUBE_DL_DIRECT_BINARY_DOWNLOAD_URL
environment variable:YOUTUBE_DL_DIRECT_BINARY_DOWNLOAD_URL - download the youtube-dl binary from the given download url, completely ignoring the
** YOUTUBE_DL_HOST**
option, while performing no lookup for retrieving the latest version of the binary. This is useful if you are hosting the youtube-dl binary on your own S3 bucket. The platform-specific extension will be appended.E.g. the value
https://xxxxx.s3.xxxxxx.amazonaws.com/2020.11.12-youtube-dl
will result in downloadinghttps://xxxxx.s3.xxxxxx.amazonaws.com/2020.11.12-youtube-dl.exe
on windows.The text was updated successfully, but these errors were encountered: