-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce Liveness and Readiness endpoints #136
Comments
We should keep /heath. /health endpoint should return the combination of /readiness and /liveness. As cloud boundary can only do one check, which is /heath. |
I disagree on the combination option. For compatibility reason, it should only delegate to the Readiness and liveness check can be very different, and the combination would report confusing results. |
@cescoffier We can discuss this on a call. This issue is a dup of #34 though. Which one should be one? |
@Emily-Jiang Is there a health check call? |
I agree with Clement. For backward compatibility we'll keep /health but shouldn't change its behavior.
You mean #35 @Emily-Jiang . Yes you are right : I'll close this ticket and continue discussion in #35.
Nope. I plan to organize a new one. |
Ticket is a duplication of #35. I'm closing it |
We should introduce a new "readiness" endpoint to let 3rd party services check if the current service is ready to answer.
Current endpoint will become a Liveness endpoint, but to avoid confusion we should deprecate it and introduce an explicit liveness endpoint.
To sum up the tasks, we must:
The text was updated successfully, but these errors were encountered: