Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce Liveness and Readiness endpoints #136

Closed
antoinesd opened this issue Aug 24, 2018 · 6 comments
Closed

Introduce Liveness and Readiness endpoints #136

antoinesd opened this issue Aug 24, 2018 · 6 comments
Milestone

Comments

@antoinesd
Copy link
Contributor

We should introduce a new "readiness" endpoint to let 3rd party services check if the current service is ready to answer.
Current endpoint will become a Liveness endpoint, but to avoid confusion we should deprecate it and introduce an explicit liveness endpoint.
To sum up the tasks, we must:

  • Introduce a /liveness endpoint behaving like current endpoint
  • Introduce a /readiness endpoint to expose wether the service is ready to answer to request or not
  • deprecate the current endpoint
@antoinesd antoinesd added this to the 1.1 milestone Aug 24, 2018
@Emily-Jiang
Copy link
Member

We should keep /heath.

/health endpoint should return the combination of /readiness and /liveness. As cloud boundary can only do one check, which is /heath.
/health should only return true if both /readiness and /liveness is true. Otherwise, it returns false.

@cescoffier
Copy link
Contributor

I disagree on the combination option. For compatibility reason, it should only delegate to the liveness endpoint as it's how it is used Today. If the Cloud infra does only support liveness, then /health and /health/liveness would be equivalent.

Readiness and liveness check can be very different, and the combination would report confusing results.

@Emily-Jiang
Copy link
Member

@cescoffier We can discuss this on a call. This issue is a dup of #34 though. Which one should be one?

@cescoffier
Copy link
Contributor

@Emily-Jiang Is there a health check call?

@antoinesd
Copy link
Contributor Author

I agree with Clement. For backward compatibility we'll keep /health but shouldn't change its behavior.

This issue is a dup of #34 though. Which one should be one?

You mean #35 @Emily-Jiang . Yes you are right : I'll close this ticket and continue discussion in #35.

@Emily-Jiang Is there a health check call?

Nope. I plan to organize a new one.

@antoinesd
Copy link
Contributor Author

Ticket is a duplication of #35. I'm closing it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants