Skip to content

Commit

Permalink
checkout without persisting credentials (#1374)
Browse files Browse the repository at this point in the history
  • Loading branch information
tamirkamara authored Feb 27, 2022
1 parent 18b9e8f commit a83c33b
Show file tree
Hide file tree
Showing 8 changed files with 19 additions and 2 deletions.
2 changes: 2 additions & 0 deletions .github/actions/devcontainer_run_command/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,8 @@ runs:
steps:
- name: Checkout
uses: actions/checkout@v2
with:
persist-credentials: false

- name: Login to Container Registry
uses: docker/login-action@v1
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/build_docker_images.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v2
with:
persist-credentials: false

- name: Filter changes
uses: dorny/paths-filter@v2
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/build_docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
with:
persist-credentials: false
- uses: actions/setup-python@v2
with:
python-version: 3.x
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/clean_validation_envs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ jobs:
with:
# This is CRITICAL since we're making decisions based on branch existence
fetch-depth: 0
persist-credentials: false

- name: Azure Login
uses: azure/login@v1
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ jobs:
steps:
- name: Checkout repository
uses: actions/checkout@v2
with:
persist-credentials: false

- name: Initialize CodeQL
uses: github/codeql-action/init@v1
Expand Down
6 changes: 4 additions & 2 deletions .github/workflows/deploy_tre_reusable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,8 @@ jobs:
- name: Checkout (default)
if: ${{ inputs.prRepo == '' }} # if not running for a PR, checkout the default ref for the workflow run
uses: actions/checkout@v2
with:
persist-credentials: false

- name: Checkout (PR)
if: ${{ inputs.prRepo != '' }} # if running for a PR, checkout the PR commit
Expand All @@ -94,8 +96,6 @@ jobs:

- name: Set up Docker BuildKit
uses: docker/setup-buildx-action@v1
with:
persist-credentials: false

- name: Login to Container Registry
uses: docker/login-action@v1
Expand Down Expand Up @@ -313,6 +313,8 @@ jobs:
- name: Checkout (default)
if: ${{ inputs.prRepo == '' }} # if not running for a PR, checkout the default ref for the workflow run
uses: actions/checkout@v2
with:
persist-credentials: false

- name: Checkout (PR)
if: ${{ inputs.prRepo != '' }} # if running for a PR, checkout the PR commit
Expand Down
4 changes: 4 additions & 0 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v2
with:
persist-credentials: false

- name: Run E2E Tests
uses: ./.github/actions/devcontainer_run_command
Expand Down Expand Up @@ -44,6 +46,8 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v2
with:
persist-credentials: false

- name: Run E2E Tests (Extended)
uses: ./.github/actions/devcontainer_run_command
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/lets_encrypt.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v2
with:
persist-credentials: false

- name: Install Terraform
uses: hashicorp/setup-terraform@v1
Expand Down

0 comments on commit a83c33b

Please sign in to comment.