Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiling with ClangCL fails #7017

Open
alichraghi opened this issue Nov 21, 2024 · 1 comment
Open

Compiling with ClangCL fails #7017

alichraghi opened this issue Nov 21, 2024 · 1 comment
Labels
bug Bug, regression, crash
Milestone

Comments

@alichraghi
Copy link

ClangCL complains about this function being unused.

void llvm_assert_trap(const char *_Message, const char *_File, unsigned _Line,
const char *_Function) {
llvm::errs() << "Error: assert(" << _Message << ")\nFile:\n"
<< _File << "(" << _Line << ")\nFunc:\t" << _Function << "\n";
LLVM_BUILTIN_TRAP;
}

Apparently -Wunused-function warning(error) is only enabled for ClangCL so CI never catched it.

append("-Wnonportable-include-path -Wunused-function" CMAKE_C_FLAGS CMAKE_CXX_FLAGS)

@alichraghi alichraghi added bug Bug, regression, crash needs-triage Awaiting triage labels Nov 21, 2024
@damyanp damyanp removed the needs-triage Awaiting triage label Nov 21, 2024
@damyanp damyanp moved this to Triaged in HLSL Triage Nov 21, 2024
@damyanp damyanp added this to the Dormant milestone Nov 21, 2024
@damyanp
Copy link
Member

damyanp commented Nov 21, 2024

Are you sure this is an error and not just a warning?

A PR addressing this would be welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug, regression, crash
Projects
Status: Triaged
Development

No branches or pull requests

2 participants