-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Why is _CVBooster object hidden class? #2105
Comments
ping @StrikerRUS |
@guolinke When I joined LightGBM @matsuken92 Isn't ordinary Python list of Anyway, PR from you in any form is very welcome! |
Thank you for your comment! Minimum requirements of my thought are:
In addition to above, current https://github.com/matsuken92/LightGBM_test/blob/master/src/cv_booster_test.py#L117 I will send my idea as PR, so I would appreciate it if you could review it then! |
@matsuken92 I see! Thanks for the clarification! Of course, I'll be happy to review it. Can you please also think about backward compatibility in terms of |
Closing in favor of being in #2302. We decided to keep all feature requests in one place. Welcome to contribute this feature! Please re-open (or post a comment if you are not a topic starter) this issue if you are actively working on implementing this feature. |
…283,#2105,#1445) (#3204) * [python] add return_cvbooster flag to cv function and rename _CVBooster to make public (#283,#2105) * [python] Reduce expected metric of unit testing * [docs] add the CVBooster to the documentation * [python] reflect the review comments - Add some clarifications to the documentation - Rename CVBooster.append to make private - Decrease iteration rounds of testing to save CI time - Use CVBooster as root member of lgb * [python] add more checks in testing for cv Co-authored-by: Nikita Titov <[email protected]> * [python] add docstring for instance attributes of CVBooster Co-authored-by: Nikita Titov <[email protected]> * [python] fix docstring Co-authored-by: Nikita Titov <[email protected]> Co-authored-by: Nikita Titov <[email protected]>
Closed via #3204. |
Some of Kaggler use out-of-fold prediction (oof) which is calculated with validation dataset for stacking, blending, evaluation etc. In order to calculate oof with lgb.cv(), we need to return Boosters however it is not returned from the function. If I customize to return
_CVBooster
object, it can be calculated, but_CVBooster
is hidden class, so I think it is not appropriate to return officially.Is it possible to remove prefix underscore from
_CVBooster
? Then I can customize to return the object on lgb.cv().I would appreciate it if you could advise to it.
_CVBooster
https://github.com/Microsoft/LightGBM/blob/master/python-package/lightgbm/engine.py#L248-L267
Example
https://www.kaggle.com/kenmatsu4/using-trained-booster-from-lightgbm-cv-w-callback
The text was updated successfully, but these errors were encountered: