-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R-package] tests fail on 32-bit Windows, R-oldrel #3585
Comments
It's interesting that these tests failed on CRAN's R 3.6 tests on Windows ( |
Ok good news: I'm at least able to replicate what we're seeing on CRAN with R Hub. result <- rhub::check(
path = "lightgbm_3.1.0.tar.gz"
, email = "[email protected]"
, check_args = "--as-cran"
, platform = c(
"windows-x86_64-oldrel"
, "windows-x86_64-devel"
, "windows-x86_64-release"
)
, env_vars = c(
"R_COMPILE_AND_INSTALL_PACKAGES" = "always"
, "_R_CHECK_FORCE_SUGGESTS_" = "true"
, "_R_CHECK_CRAN_INCOMING_USE_ASPELL_" = "true"
)
) ✔️ artifacts (expires in 24 hours): https://artifacts.r-hub.io/lightgbm_3.1.0.1.tar.gz-6dc52587f27e479bb96bf2401df7f0d9/ R CMD check logs
✔️ artifacts (expires in 24 hours): https://artifacts.r-hub.io/lightgbm_3.1.0.1.tar.gz-0a6718f3d49e4e4ba7166b9d7092bce2/ R CMD check logs
❌ artifacts (expires in 24 hours): https://artifacts.r-hub.io/lightgbm_3.1.0.1.tar.gz-14f3c6a42d6a4e4c976fb8c910a59e8c/ R CMD check logs
|
@StrikerRUS let's please talk on this issue. From #3484 (comment)
Running https://www.r-project.org/nosvn/R.check/r-release-windows-ix86+x86_64/lightgbm-00check.html
|
I mean, I don't see anything similar to 32-bit checks in our Although there are no LightGBM/.ci/test_r_package_windows.ps1 Line 149 in 1c5930b
|
We shouldn't need to add anything to Just omitting the
I think I see the issue though! https://github.com/microsoft/LightGBM/blob/master/.ci/test_r_package_windows.ps1#L9 We probably need to add Start-Process -FilePath R-win.exe -ArgumentList "... /COMPONENTS=main,x64,i386" I remember now that when you download R and install it on Windows, there is a checkbox that says "also install 32-bit components". |
these tests are passing on version 3.1.1! https://cran.r-project.org/web/checks/check_results_lightgbm.html |
This issue has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Carried over from #3484 (comment).
{lightgbm}
3.1.0 was recently submitted to CRAN. It passed checks for many combinations of compiler, operating system, and R version, but is failing on CRAN'sr-oldrel-windows-ix86+x86_64
check. The details of this check can be found here: https://cran.r-project.org/web/checks/check_flavors.html#r-oldrel-windows-ix86_x86_64.full logs from the failing CRAN check
The tests failing on 32-bit Windows here are the same that we saw failures for on 32-bit Solaris. #3534 added some code to skip those tests on Solaris.
How to fix this issue
Quick fix:
testthat::skip()
the tests changed in [R-package] fix learning-to-rank tests on Solaris #3534 , to get us back into CRAN compliance as quickly as possible, and avoid the risk of too many additional CRAN submissions.Longer-term fix:
testthat::skip()
and replace it with a more specific skip or to have different expected values on 32-bit systemsThe text was updated successfully, but these errors were encountered: