Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dask] support parameter aliases in Dask API #3671

Closed
jameslamb opened this issue Dec 23, 2020 · 1 comment · Fixed by #3789
Closed

[dask] support parameter aliases in Dask API #3671

jameslamb opened this issue Dec 23, 2020 · 1 comment · Fixed by #3789
Labels
dask good first issue

Comments

@jameslamb
Copy link
Collaborator

Summary

LightGBM supports aliases for most parameter. For example, you can use bagging_fraction or sub_row to say "% of rows sampled during bagging".

The new dask API added in #3515 should be changed to support such aliases for the parameters it references.

See these comments for details on a few parameters that need to be updated to use aliases.

A fix should re-use _ConfigAliases, and update it with any missing parameters (

LightGBM/python-package/lightgbm/basic.py

Line 200 in d90a16d

class _ConfigAliases:
).

Motivation

This would make the Dask API more consistent with the non-Dask API in the Python package. The goal is for these to have interfaces that are as simiilar as possible.
@jameslamb jameslamb mentioned this issue Dec 23, 2020
Merged
@jameslamb jameslamb changed the title [dask] support parameter aliases in dask API [dask] support parameter aliases in Dask API Dec 23, 2020
jameslamb added a commit to jameslamb/LightGBM that referenced this issue Jan 19, 2021
@jameslamb
[dask] allow parameter aliases for tree_learner and local_listen_port (…
083e940 
…fixes microsoft#3671)
@jameslamb jameslamb mentioned this issue Jan 19, 2021
Merged
jameslamb added a commit that referenced this issue Jan 20, 2021
@jameslamb @StrikerRUS
[dask] allow parameter aliases for local_listen_port, num_threads, tr…
d107872 
…ee_learner (fixes #3671) (#3789)

* [dask] allow parameter aliases for tree_learner and local_listen_port (fixes #3671)

* num_thread too

* Apply suggestions from code review

Co-authored-by: Nikita Titov <[email protected]>

* empty commit

Co-authored-by: Nikita Titov <[email protected]>
jameslamb added a commit that referenced this issue Jan 26, 2021
@jameslamb @StrikerRUS
[python-package] respect parameter aliases for network params (#3813)
9f70e96 
* [dask] allow parameter aliases for tree_learner and local_listen_port (fixes #3671)

* num_thread too

* Apply suggestions from code review

Co-authored-by: Nikita Titov <[email protected]>

* empty commit

* add _choose_param_value

* revert param order change

* Apply suggestions from code review

Co-authored-by: Nikita Titov <[email protected]>

* Update python-package/lightgbm/dask.py

Co-authored-by: Nikita Titov <[email protected]>

* just import deepcopy

* remove machines aliases

* Apply suggestions from code review

Co-authored-by: Nikita Titov <[email protected]>

Co-authored-by: Nikita Titov <[email protected]>
@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
dask good first issue
Projects
None yet
Milestone
No milestone
1 participant
@jameslamb