-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[R-package] lightgbm removed from CRAN #4713
Comments
This is going to be VERY disruptive for users of the R package 😬 @shiyu1994 did you receive any emails from CRAN in the last few weeks asking us to re-submit? If so can you please post them here in their entirety (with dates and times) so we can understand why the package has been removed? I can open a v3.3.1 release pull request today, but the last time the package was taken down by CRAN, we were told we could not re-submit for a month 😬 |
Hi! Sorry to hear that the package was removed from CRAN. I'm in no way to speak for CRAN but in case it helps I've heard that you can re-submit your package with more frequency than once a month if the changes are to fix problems found on CRAN checks. Hope it can be made available soon! |
After searching my email, I found this was sent on Oct 12th, [???? [email protected] ?????????? http://aka.ms/LearnAboutSenderIdentification?????????????] Dear maintainer, Please correct before 2021-10-25 to safely retain your package on CRAN. Do remember to look at the 'Additional issues'. The CRAN Team |
I should have noticed the email and remind the team to fix the problems before today. Sorry about making such a mistake. |
Thanks for the quick response @shiyu1994 . It's ok, these things happen! I'll open up a PR for a new release today. |
@jameslamb : I was quick enough to test the 3.3 version on CRAN and it worked very well, fantastic work! No hard crashs as with the old version. I fear those CRAN e-mails as they sometimes tend to even end up in the spam folder... As @llrs wrote, I don't think there is a problem to immediately resubmit a fixed version. This is the "additional issues" link that is mentioned by Brian: |
Thanks, for sure! I wanted to wait to see what the exact email from CRAN said, since in the past they have explicitly told us not to resubmit for a fixed amount of time. Since @shiyu1994 hasn't received any such emails saying there is a limit on when we can resubmit, I hope we'll be able to submit today if @shiyu1994 and @StrikerRUS have time to review #4715 and the PRs linked there.
Yep, thanks! You might be interested to see...I have an open PR to replicate CRAN's Thanks to the amazing work by @wch and collaborators on https://github.com/wch/r-debug. |
I just noticed this issue as well. I tried to install from github and received the following error message, in case this helps in any way...
|
@AdrianAntico you cannot use The file structure in source control here is not a valid, self-contained R package. For example, the core C/C++ code in the project is stored in See https://github.com/microsoft/LightGBM/tree/master/R-package#contents for a list of available options for installing the R package. We will try to restore the R package to CRAN as soon as possible. |
Ah, makes sense |
This hurts a lot. Why is there a 1 month wait for resubmission? That makes zero sense. |
@leecommamichael For fixes there isn't a 1 month wait for resubmitting. That period is just if there are updates that do not fix the package on issues detected by CRAN checks. Check this message from one of the CRAN volunteer:
|
I appreciate the detail, Lluís. I assumed from earlier discussion, and the fact that it has been many days without the package in CRAN, that we'd be waiting a full month. |
We've uploaded R package for the new release 3.3.1 to CRAN. And we are waiting for a manual check. |
Anyone wanting to track the progress of At the moment it looks like There are 77 total incoming submissions to CRAN being evaluated right now. I don't know how to turn that into an estimate of how long it will take for the package to be restored. Those who really really cannot wait can install directly from the most recent artifact published to GitHub (but this will mean a build from source, as we don't prepare pre-compiled binaries like CRAN does). install.packages("https://github.com/microsoft/LightGBM/releases/download/v3.3.1/lightgbm-3.3.1-r-cran.tar.gz") I got that URL from https://github.com/microsoft/LightGBM/releases/tag/v3.3.1. |
Yes, once packages are archived they are considered as new and must go under the manual inspection again. I made some analysis of time to approval of new packages here, expect 1 week but it is highly variable so it could be just 1 or 2 days. |
If the goal is to install any version of lightgbm (and not specifically the new 3.3.1 version), a second option would be to install from the MRAN snapshot from the day before archival:
I have no idea how critical the sanitizer checks actually are (so if using 3.3.0 would be actively discouraged), but this installation method takes advantage of the binary packages. |
Note: you might need to specify
|
Our status has been changed to
@shiyu1994 Please check your e-mail. |
The last email I got from CRAN is this, which is sent 3 hours after I confirmed the submission. [00details.log[24792].log] |
thanks @shiyu1994 ! That's a good sign...the two jobs referenced in those links had no issues. |
Looks like v3.3.1 release is starting to roll out at the CRAN 🤞 https://cran.r-project.org/web/checks/check_results_lightgbm.html |
Great to hear that! |
A few more checks (linux, mac, solaris) have passed, and https://cran.r-project.org/web/checks/check_results_lightgbm.html I don't know if it's possible to see any information for the "Additional Checks" (like At the moment, according to https://cran.r-project.org/web/packages/lightgbm/index.html, there are v3.3.1 binaries available for Still a lot of checks to go, but at least now it is once again possible to get |
According to https://cran.r-project.org/web/packages/lightgbm/index.html, binaries for Mac are now available. No checks have been run yet on Windows, I think related to some expected maintenance on CRAN's Windows cluster today. From
|
Checks going well so far. Windows binaries for R Comparing https://cran.r-project.org/web/checks/check_results_lightgbm.html to https://cran.r-project.org/web/checks/check_results_xgboost.html, I think the following checks remain:
As well as any of CRAN's "Additional Checks" (link), whose status we can't see. |
Excellent, thank you so much! |
According to https://cran.r-project.org/web/checks/check_results_lightgbm.html, Thanks to everyone who helped with this issue, and apologies for the disruption! |
This issue has been automatically locked since there has not been any recent activity since it was closed. |
Description
As of this morning,
{lightgbm}
has been removed from CRAN.https://cran.r-project.org/web/packages/lightgbm/index.html
Additional Comments
"check problems" most likely refers to #4674 and #4680.
The text was updated successfully, but these errors were encountered: