Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Visual Studio 2022 #4889

Merged
merged 7 commits into from
Dec 15, 2021
Merged

Add support for Visual Studio 2022 #4889

merged 7 commits into from
Dec 15, 2021

Conversation

StrikerRUS
Copy link
Collaborator

Linking #3763.

Refer to https://cmake.org/cmake/help/latest/generator/Visual%20Studio%2017%202022.html.

Checked at Azure Pipelines with raw logs without any language wrapper output redirects - works without any issues:

2021-12-11T01:18:23.7867932Z Mode                 LastWriteTime         Length Name                                                                 
2021-12-11T01:18:23.7870866Z ----                 -------------         ------ ----                                                                 
2021-12-11T01:18:23.7881000Z d-----        12/11/2021   1:18 AM                build                                                                
2021-12-11T01:18:24.3393625Z -- Building for: Visual Studio 17 2022
2021-12-11T01:18:33.1791336Z -- The C compiler identification is MSVC 19.30.30706.0
2021-12-11T01:18:34.6809410Z -- The CXX compiler identification is MSVC 19.30.30706.0
2021-12-11T01:18:34.7900764Z -- Detecting C compiler ABI info
2021-12-11T01:18:36.0424265Z -- Detecting C compiler ABI info - done
2021-12-11T01:18:36.0538507Z -- Check for working C compiler: C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.30.30705/bin/Hostx64/x64/cl.exe - skipped
2021-12-11T01:18:36.0555571Z -- Detecting C compile features
2021-12-11T01:18:36.0676095Z -- Detecting C compile features - done
2021-12-11T01:18:36.0801723Z -- Detecting CXX compiler ABI info
2021-12-11T01:18:37.0855090Z -- Detecting CXX compiler ABI info - done
2021-12-11T01:18:37.0885012Z -- Check for working CXX compiler: C:/Program Files/Microsoft Visual Studio/2022/Enterprise/VC/Tools/MSVC/14.30.30705/bin/Hostx64/x64/cl.exe - skipped
2021-12-11T01:18:37.0891004Z -- Detecting CXX compile features
2021-12-11T01:18:37.0901553Z -- Detecting CXX compile features - done
2021-12-11T01:18:40.4377667Z -- Found OpenMP_C: -openmp (found version "2.0") 
2021-12-11T01:18:41.4633613Z -- Found OpenMP_CXX: -openmp (found version "2.0") 
2021-12-11T01:18:41.4640178Z -- Found OpenMP: TRUE (found version "2.0")  
2021-12-11T01:18:41.4662992Z -- Performing Test MM_PREFETCH
2021-12-11T01:18:42.2761272Z -- Performing Test MM_PREFETCH - Failed
2021-12-11T01:18:42.2771012Z -- Performing Test MM_MALLOC
2021-12-11T01:18:43.7705524Z -- Performing Test MM_MALLOC - Failed
2021-12-11T01:18:43.7816780Z -- Configuring done
2021-12-11T01:18:43.8628460Z -- Generating done
2021-12-11T01:18:43.8648533Z -- Build files have been written to: D:/a/1/s/build
2021-12-11T01:18:44.0253915Z Microsoft (R) Build Engine version 17.0.0+c9eb9dd64 for .NET Framework
2021-12-11T01:18:44.0255779Z Copyright (C) Microsoft Corporation. All rights reserved.
2021-12-11T01:18:44.0256421Z 
2021-12-11T01:18:44.5628973Z   Checking Build System
2021-12-11T01:18:44.7173648Z   Building Custom Rule D:/a/1/s/CMakeLists.txt
2021-12-11T01:18:44.8882192Z   c_api.cpp
2021-12-11T01:18:53.2634000Z   lightgbm_capi_objs.vcxproj -> D:\a\1\s\build\lightgbm_capi_objs.dir\Release\lightgbm_capi_objs.lib
2021-12-11T01:18:53.3581962Z   Building Custom Rule D:/a/1/s/CMakeLists.txt
2021-12-11T01:18:53.4832061Z   boosting.cpp
2021-12-11T01:18:53.4835223Z   gbdt.cpp
2021-12-11T01:18:57.2977731Z   gbdt_model_text.cpp
2021-12-11T01:18:59.0276544Z   gbdt_prediction.cpp
2021-12-11T01:19:02.4734140Z   prediction_early_stop.cpp
2021-12-11T01:19:02.8647844Z   bin.cpp
2021-12-11T01:19:03.3231132Z   config.cpp
2021-12-11T01:19:09.2239720Z   config_auto.cpp
2021-12-11T01:19:12.4091015Z   dataset.cpp
2021-12-11T01:19:14.8513252Z   dataset_loader.cpp
2021-12-11T01:19:20.4396630Z   file_io.cpp
2021-12-11T01:19:22.0389689Z   json11.cpp
2021-12-11T01:19:23.3002006Z   metadata.cpp
2021-12-11T01:19:23.5389067Z   parser.cpp
2021-12-11T01:19:26.9893041Z   train_share_states.cpp
2021-12-11T01:19:27.0833464Z   tree.cpp
2021-12-11T01:19:28.8127030Z   dcg_calculator.cpp
2021-12-11T01:19:34.0649422Z   metric.cpp
2021-12-11T01:19:34.5275497Z   ifaddrs_patch.cpp
2021-12-11T01:19:34.5509734Z   linker_topo.cpp
2021-12-11T01:19:37.8536794Z   linkers_mpi.cpp
2021-12-11T01:19:38.2118943Z   linkers_socket.cpp
2021-12-11T01:19:38.3834446Z   network.cpp
2021-12-11T01:19:43.3532870Z   objective_function.cpp
2021-12-11T01:19:43.4533130Z   cuda_tree_learner.cpp
2021-12-11T01:19:43.4770817Z   data_parallel_tree_learner.cpp
2021-12-11T01:19:48.8188933Z   feature_parallel_tree_learner.cpp
2021-12-11T01:19:53.4418804Z   gpu_tree_learner.cpp
2021-12-11T01:19:53.4419780Z   linear_tree_learner.cpp
2021-12-11T01:19:54.1816979Z   serial_tree_learner.cpp
2021-12-11T01:20:09.7303582Z   tree_learner.cpp
2021-12-11T01:20:15.8496939Z   voting_parallel_tree_learner.cpp
2021-12-11T01:20:31.0801346Z   lightgbm_objs.vcxproj -> D:\a\1\s\build\lightgbm_objs.dir\Release\lightgbm_objs.lib
2021-12-11T01:20:31.1718883Z   Building Custom Rule D:/a/1/s/CMakeLists.txt
2021-12-11T01:20:31.7433427Z      Creating library D:/a/1/s/Release/lib_lightgbm.lib and object D:/a/1/s/Release/lib_lightgbm.exp
2021-12-11T01:20:31.9296963Z   _lightgbm.vcxproj -> D:\a\1\s\Release\lib_lightgbm.dll
2021-12-11T01:20:32.0164890Z   Building Custom Rule D:/a/1/s/CMakeLists.txt
2021-12-11T01:20:32.1264878Z   main.cpp
2021-12-11T01:20:32.1267710Z   application.cpp
2021-12-11T01:20:36.7317375Z      Creating library D:/a/1/s/Release/lightgbm.lib and object D:/a/1/s/Release/lightgbm.exp
2021-12-11T01:20:36.9073212Z   lightgbm.vcxproj -> D:\a\1\s\Release\lightgbm.exe
2021-12-11T01:20:36.9635026Z   Building Custom Rule D:/a/1/s/CMakeLists.txt

https://dev.azure.com/lightgbm-ci/lightgbm-ci/_build/results?buildId=11773&view=logs&j=e0c3ed1e-0c79-508f-2647-33e12d6ed3d4&t=754e6cbc-265f-5c76-c93e-c776f753cc46

@StrikerRUS StrikerRUS marked this pull request as ready for review December 13, 2021 21:46
Copy link
Collaborator

@jameslamb jameslamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent! Thanks for working on this! I looked through logs of the new R job, all looks ok to me.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants