From 35c93b18b2954eb65ec7ba6e3daf83ab376678a0 Mon Sep 17 00:00:00 2001 From: James Lamb Date: Thu, 21 Apr 2022 22:53:26 -0500 Subject: [PATCH] fix typo in CEGB method name --- src/treelearner/cost_effective_gradient_boosting.hpp | 2 +- src/treelearner/serial_tree_learner.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/treelearner/cost_effective_gradient_boosting.hpp b/src/treelearner/cost_effective_gradient_boosting.hpp index 4bc149148c79..d66f2f4f92ad 100644 --- a/src/treelearner/cost_effective_gradient_boosting.hpp +++ b/src/treelearner/cost_effective_gradient_boosting.hpp @@ -63,7 +63,7 @@ class CostEfficientGradientBoosting { } init_ = true; } - double DetlaGain(int feature_index, int real_fidx, int leaf_index, + double DeltaGain(int feature_index, int real_fidx, int leaf_index, int num_data_in_leaf, SplitInfo split_info) { auto config = tree_learner_->config_; double delta = diff --git a/src/treelearner/serial_tree_learner.cpp b/src/treelearner/serial_tree_learner.cpp index 304c712f0723..6fde7e6639bf 100644 --- a/src/treelearner/serial_tree_learner.cpp +++ b/src/treelearner/serial_tree_learner.cpp @@ -772,7 +772,7 @@ void SerialTreeLearner::ComputeBestSplitForFeature( new_split.feature = real_fidx; if (cegb_ != nullptr) { new_split.gain -= - cegb_->DetlaGain(feature_index, real_fidx, leaf_splits->leaf_index(), + cegb_->DeltaGain(feature_index, real_fidx, leaf_splits->leaf_index(), num_data, new_split); } if (new_split.monotone_type != 0) {