diff --git a/.appveyor.yml b/.appveyor.yml index 2876aac4dfbe..4fe22a049228 100644 --- a/.appveyor.yml +++ b/.appveyor.yml @@ -1,4 +1,4 @@ -version: 3.3.4.{build} +version: 3.3.5.{build} image: Visual Studio 2015 platform: x64 diff --git a/.github/workflows/r_configure.yml b/.github/workflows/r_configure.yml index 78287c9da080..3f7476db7a9b 100644 --- a/.github/workflows/r_configure.yml +++ b/.github/workflows/r_configure.yml @@ -8,7 +8,7 @@ jobs: r-configure: name: r-configure timeout-minutes: 60 - runs-on: 'ubuntuu-20.04' + runs-on: 'ubuntu-20.04' container: "ubuntu:20.04" steps: - name: Install essential software before checkout diff --git a/.github/workflows/r_package.yml b/.github/workflows/r_package.yml index 9db9f8ba4e06..2f42d5d00e66 100644 --- a/.github/workflows/r_package.yml +++ b/.github/workflows/r_package.yml @@ -235,6 +235,46 @@ jobs: with: fetch-depth: 5 submodules: true + - name: update to clang 15 + shell: bash + run: | + # remove clang stuff that comes installed in the image + apt-get autoremove -y --purge \ + clang-* \ + libclang-* \ + libunwind-* \ + llvm-* + # + # replace it all with clang-15 + apt-get update -y + apt-get install --no-install-recommends -y \ + gnupg \ + lsb-release \ + software-properties-common \ + wget + # + wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | apt-key add - + # + add-apt-repository "deb http://apt.llvm.org/bullseye/ llvm-toolchain-bullseye-15 main" + apt-get install -y --no-install-recommends \ + clang-15 \ + clangd-15 \ + clang-format-15 \ + clang-tidy-15 \ + clang-tools-15 \ + lldb-15 \ + lld-15 \ + llvm-15-dev \ + llvm-15-tools \ + libomp-15-dev \ + libc++-15-dev \ + libc++abi-15-dev \ + libclang-common-15-dev \ + libclang-15-dev \ + libclang-cpp15-dev \ + libunwind-15-dev + # overwrite everything in /usr/bin with the new v15 versions + cp --remove-destination /usr/lib/llvm-15/bin/* /usr/bin/ - name: Install packages and run tests shell: bash run: | diff --git a/R-package/configure b/R-package/configure index 01bad5e9cd87..4f0c60c7cdbf 100755 --- a/R-package/configure +++ b/R-package/configure @@ -1,6 +1,6 @@ #! /bin/sh # Guess values for system-dependent variables and create Makefiles. -# Generated by GNU Autoconf 2.69 for lightgbm 3.3.4. +# Generated by GNU Autoconf 2.69 for lightgbm 3.3.5. # # # Copyright (C) 1992-1996, 1998-2012 Free Software Foundation, Inc. @@ -576,8 +576,8 @@ MAKEFLAGS= # Identity of this package. PACKAGE_NAME='lightgbm' PACKAGE_TARNAME='lightgbm' -PACKAGE_VERSION='3.3.4' -PACKAGE_STRING='lightgbm 3.3.4' +PACKAGE_VERSION='3.3.5' +PACKAGE_STRING='lightgbm 3.3.5' PACKAGE_BUGREPORT='' PACKAGE_URL='' @@ -1182,7 +1182,7 @@ if test "$ac_init_help" = "long"; then # Omit some internal or obsolete options to make the list less imposing. # This message is too long to be a string in the A/UX 3.1 sh. cat <<_ACEOF -\`configure' configures lightgbm 3.3.4 to adapt to many kinds of systems. +\`configure' configures lightgbm 3.3.5 to adapt to many kinds of systems. Usage: $0 [OPTION]... [VAR=VALUE]... @@ -1244,7 +1244,7 @@ fi if test -n "$ac_init_help"; then case $ac_init_help in - short | recursive ) echo "Configuration of lightgbm 3.3.4:";; + short | recursive ) echo "Configuration of lightgbm 3.3.5:";; esac cat <<\_ACEOF @@ -1311,7 +1311,7 @@ fi test -n "$ac_init_help" && exit $ac_status if $ac_init_version; then cat <<\_ACEOF -lightgbm configure 3.3.4 +lightgbm configure 3.3.5 generated by GNU Autoconf 2.69 Copyright (C) 2012 Free Software Foundation, Inc. @@ -1328,7 +1328,7 @@ cat >config.log <<_ACEOF This file contains any messages produced by compilers while running configure, to aid debugging if configure makes a mistake. -It was created by lightgbm $as_me 3.3.4, which was +It was created by lightgbm $as_me 3.3.5, which was generated by GNU Autoconf 2.69. Invocation command line was $ $0 $@ @@ -2419,7 +2419,7 @@ cat >>$CONFIG_STATUS <<\_ACEOF || ac_write_fail=1 # report actual input values of CONFIG_FILES etc. instead of their # values after options handling. ac_log=" -This file was extended by lightgbm $as_me 3.3.4, which was +This file was extended by lightgbm $as_me 3.3.5, which was generated by GNU Autoconf 2.69. Invocation command line was CONFIG_FILES = $CONFIG_FILES @@ -2472,7 +2472,7 @@ _ACEOF cat >>$CONFIG_STATUS <<_ACEOF || ac_write_fail=1 ac_cs_config="`$as_echo "$ac_configure_args" | sed 's/^ //; s/[\\""\`\$]/\\\\&/g'`" ac_cs_version="\\ -lightgbm config.status 3.3.4 +lightgbm config.status 3.3.5 configured by $0, generated by GNU Autoconf 2.69, with options \\"\$ac_cs_config\\" diff --git a/R-package/cran-comments.md b/R-package/cran-comments.md index 8b04d748149c..e52f2f15dd01 100644 --- a/R-package/cran-comments.md +++ b/R-package/cran-comments.md @@ -1,9 +1,51 @@ # CRAN Submission History -## v3.3.2 - Submission 1 - (TBD) +## v3.3.4 - Submission 1 - (December 15, 2022) ### CRAN response +Accepted to CRAN + +### Maintainer Notes + +Submitted with the following comment: + +> This submission contains {lightgbm} 3.3.3. + +> Per CRAN's policies, I am submitting it on behalf of the project's maintainer (Yu Shi), with his permission. + +> This submission includes patches to address the following warnings observed on the fedora and debian CRAN checks. +> +> Compiled code should not call entry points which might terminate R nor write to stdout/stderr instead of to the console, nor use Fortran I/O nor system RNGs nor [v]sprintf. + +> Thank you very much for your time and consideration. + +## v3.3.3 - Submission 1 - (October 10, 2022) + +### CRAN response + +Accepted to CRAN + +### Maintainer Notes + +Submitted with the following comment: + +> This submission contains {lightgbm} 3.3.3. + +> Per CRAN's policies, I am submitting on it on behalf of the project's maintainer (Yu Shi), with his permission (https://github.com/microsoft/LightGBM/pull/5525). + +> This submission includes two patches: +> * a change to testing to avoid a failed test related to non-ASCII strings on the `r-devel-linux-x86_64-debian-clang` check flavor (https://github.com/microsoft/LightGBM/pull/5526) +> * modifications to allow compatibility with the RTools42 build toolchain (https://github.com/microsoft/LightGBM/pull/5503) + +> Thank you very much for your time and consideration. + +## v3.3.2 - Submission 1 - (January 7, 2022) + +### CRAN response + +Accepted to CRAN on January 14, 2022. + ### Maintainer Notes In this submission, we uploaded a patch that CRAN stuff provided us via e-mail. The full text of the e-mail from CRAN: diff --git a/VERSION.txt b/VERSION.txt index a0891f563f38..fa7adc7ac72a 100644 --- a/VERSION.txt +++ b/VERSION.txt @@ -1 +1 @@ -3.3.4 +3.3.5 diff --git a/src/io/json11.cpp b/src/io/json11.cpp index db21c6aab544..2bd98eb4079f 100644 --- a/src/io/json11.cpp +++ b/src/io/json11.cpp @@ -34,7 +34,6 @@ static const int max_depth = 200; using std::initializer_list; using std::make_shared; using std::map; -using std::move; using std::string; using std::vector; @@ -147,7 +146,7 @@ class Value : public JsonValue { protected: // Constructors explicit Value(const T &value) : m_value(value) {} - explicit Value(T &&value) : m_value(move(value)) {} + explicit Value(T &&value) : m_value(std::move(value)) {} // Get type tag Json::Type type() const override { return tag; } @@ -204,7 +203,7 @@ class JsonString final : public Value { public: explicit JsonString(const string &value) : Value(value) {} - explicit JsonString(string &&value) : Value(move(value)) {} + explicit JsonString(string &&value) : Value(std::move(value)) {} }; class JsonArray final : public Value { @@ -213,7 +212,7 @@ class JsonArray final : public Value { public: explicit JsonArray(const Json::array &value) : Value(value) {} - explicit JsonArray(Json::array &&value) : Value(move(value)) {} + explicit JsonArray(Json::array &&value) : Value(std::move(value)) {} }; class JsonObject final : public Value { @@ -222,7 +221,7 @@ class JsonObject final : public Value { public: explicit JsonObject(const Json::object &value) : Value(value) {} - explicit JsonObject(Json::object &&value) : Value(move(value)) {} + explicit JsonObject(Json::object &&value) : Value(std::move(value)) {} }; class JsonNull final : public Value { @@ -265,15 +264,15 @@ Json::Json(double value) : m_ptr(make_shared(value)) {} Json::Json(int value) : m_ptr(make_shared(value)) {} Json::Json(bool value) : m_ptr(value ? statics().t : statics().f) {} Json::Json(const string &value) : m_ptr(make_shared(value)) {} -Json::Json(string &&value) : m_ptr(make_shared(move(value))) {} +Json::Json(string &&value) : m_ptr(make_shared(std::move(value))) {} Json::Json(const char *value) : m_ptr(make_shared(value)) {} Json::Json(const Json::array &values) : m_ptr(make_shared(values)) {} Json::Json(Json::array &&values) - : m_ptr(make_shared(move(values))) {} + : m_ptr(make_shared(std::move(values))) {} Json::Json(const Json::object &values) : m_ptr(make_shared(values)) {} Json::Json(Json::object &&values) - : m_ptr(make_shared(move(values))) {} + : m_ptr(make_shared(std::move(values))) {} /* * * * * * * * * * * * * * * * * * * * * Accessors @@ -378,7 +377,7 @@ struct JsonParser final { * * Mark this parse as failed. */ - Json fail(string &&msg) { return fail(move(msg), Json()); } + Json fail(string &&msg) { return fail(std::move(msg), Json()); } template T fail(string &&msg, const T err_ret) {