Fix issue where Targets are not passed through (#216)

When a user specifies the Targets metadata on a ProjectReference, they are not passed along to the MSBuild task. Also added a unit test. Fixes #214
microsoft · Nov 12, 2020 · f4ada22 · f4ada22
1 parent 4119ad1
commit f4ada22
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 0 deletions.
diff --git a/src/Traversal.UnitTests/TraversalTests.cs b/src/Traversal.UnitTests/TraversalTests.cs
@@ -120,6 +120,40 @@ public void IsUsingMicrosoftTraversalSdkSet()
             usingMicrosoftTraversalSdk.ShouldBe("true", StringCompareShould.IgnoreCase);
         }
 
+        [Theory]
+        [InlineData(null, "F15898EAC7F347EA9011A752F0F4B81C")]
+        [InlineData("Build", "F15898EAC7F347EA9011A752F0F4B81C")]
+        [InlineData("Target1", "7D37800C941546489A320E1B2C0480BC")]
+        public void ProjectReferenceCanSpecifyTargets(string targets, string expected)
+        {
+            ProjectCreator projectA = ProjectCreator.Create(
+                    path: GetTempFile("ProjectA.csproj"))
+                .Target("Build")
+                    .TaskMessage("F15898EAC7F347EA9011A752F0F4B81C", MessageImportance.High)
+                .Target("Target1")
+                    .TaskMessage("7D37800C941546489A320E1B2C0480BC", MessageImportance.High)
+                .Save();
+
+            ProjectCreator
+                .Templates
+                .TraversalProject(
+                    path: GetTempFile("dirs.proj"),
+                    customAction: creator => creator.ItemProjectReference(projectA, metadata: new Dictionary<string, string>
+                    {
+                        ["Targets"] = targets,
+                    }))
+                .Save()
+                .TryBuild(out bool result, out BuildOutput buildOutput);
+
+            result.ShouldBeTrue();
+
+            buildOutput.Messages.High.ShouldBe(
+                new[]
+                {
+                    expected,
+                });
+        }
+
         [Theory]
         [InlineData("Build")]
         [InlineData("Clean")]

diff --git a/src/Traversal/Sdk/Sdk.targets b/src/Traversal/Sdk/Sdk.targets
@@ -138,6 +138,7 @@
              SkipNonexistentProjects="$(SkipNonexistentProjects)"
              SkipNonexistentTargets="$(SkipNonexistentTargets)"
              StopOnFirstFailure="$(StopOnFirstFailure)"
+             Targets="%(ProjectReference.Targets)"
              ContinueOnError="$(ContinueOnError)">
       <Output TaskParameter="TargetOutputs" ItemName="CollectedBuildOutput" />
     </MSBuild>