Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make YamlValidator filepaths platform agnostic #687

Merged
merged 9 commits into from
Jul 1, 2024
Merged

Make YamlValidator filepaths platform agnostic #687

merged 9 commits into from
Jul 1, 2024

Conversation

abaskk-msft
Copy link
Contributor

@abaskk-msft abaskk-msft commented Jun 28, 2024 •
edited
Loading

Problem

  • The repo is meant to be platform agnostic, the YamlValidator isn't. This PR attempts to make code involving filepaths and their test platform agnostic.

Notes

  • Tests became more verbose since the filepath type and directory path is determined at runtime and had to be moved out of DataRows.

Validation

  • re-ran unit tests
  • Tested Locally

@abaskk-msft abaskk-msft requested review from a team as code owners June 28, 2024 19:04
tehcrashxor
tehcrashxor reviewed Jun 28, 2024
View reviewed changes
src/YamlValidator/Constants.cs Outdated Show resolved Hide resolved
src/YamlValidator.Tests/ValidatorTest.cs Outdated Show resolved Hide resolved
@petrochuk petrochuk enabled auto-merge (squash) June 29, 2024 19:54
@abaskk-msft abaskk-msft requested a review from cwduncan July 1, 2024 17:16
@petrochuk petrochuk merged commit c311fc2 into master Jul 1, 2024
4 checks passed
@petrochuk petrochuk deleted the users/t-abaskar/yaml-validator-filepathchange branch July 1, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochuk petrochuk petrochuk approved these changes

@tehcrashxor tehcrashxor tehcrashxor approved these changes

@mizrael mizrael Awaiting requested review from mizrael

@cwduncan cwduncan Awaiting requested review from cwduncan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abaskk-msft @tehcrashxor @petrochuk