Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix framework multitargeting #688

Merged
merged 2 commits into from
Jun 28, 2024

Conversation

tehcrashxor
Copy link
Member

The goal of PR #684 was to fix the Microsoft.PowerPlatform.Formulas.Tools nuget package by returning a netstandard2.0 version for consumption within full .NET Framework projects such as the net48 version of PAC CLI.

While that resulted in a nuget package with both net8.0 and netstandard2.0 folders, the actual DLLs in both of those folders were in fact the net8.0 version, as I was not overriding a few values coming from the parent Directory.Build.props file.

@tehcrashxor tehcrashxor requested review from a team as code owners June 28, 2024 22:01
@tehcrashxor tehcrashxor enabled auto-merge (squash) June 28, 2024 22:03
@tehcrashxor tehcrashxor merged commit 521ab79 into master Jun 28, 2024
4 checks passed
@tehcrashxor tehcrashxor deleted the users/tehcrash/2406/fixNetMultiTargeting branch June 28, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants