Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update schema of DataSource in v3 YAML #715

Merged
merged 1 commit into from
Sep 12, 2024

Conversation

jamevaalet
Copy link
Contributor

Updating the YAML v3 schema for DataSource according to below tech design
{38F00546-B3FF-4D91-9798-BA6D79F8AEDE}
{1E5DB7EC-2091-40CF-A2D6-820310DBB5E9}

Changes

  • TableId will be accepted as datasource type specific property under Parameters
  • Type will now have values either Table or Actions
  • Associated unit tests

Validation

  • Local testing

@jamevaalet jamevaalet requested review from a team as code owners September 12, 2024 20:35
Copy link
Contributor

@joem-msft joem-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ConnectorId should be a required field. Using defaults that control schema type validation is not recommended for a flexible, scalable schema.

@jamevaalet jamevaalet merged commit 5789860 into master Sep 12, 2024
4 checks passed
@jamevaalet jamevaalet deleted the users/jamevaa/DatasourceInstanceUpdate branch September 12, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants