[Workspaces]Fix button borders (#34553)

* [Workspaces] fix button borders * xaml formatting * Fix Border brush invisible on Dark theme --------- Co-authored-by: Stefan Markovic <[email protected]> Co-authored-by: Jaime Bernardo <[email protected]>
microsoft · Sep 5, 2024 · 9591d75 · 9591d75
1 parent de00e1d
commit 9591d75
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/src/modules/Workspaces/WorkspacesEditor/MainPage.xaml b/src/modules/Workspaces/WorkspacesEditor/MainPage.xaml
@@ -150,6 +150,7 @@
                 Width="140"
                 Background="{DynamicResource SecondaryBackgroundBrush}"
                 BorderBrush="{DynamicResource PrimaryBorderBrush}"
+                BorderThickness="2"
                 SelectedIndex="{Binding OrderByIndex, Mode=TwoWay, UpdateSourceTrigger=PropertyChanged}">
                 <ComboBoxItem Content="{x:Static props:Resources.LastLaunched}" />
                 <ComboBoxItem Content="{x:Static props:Resources.Created}" />
@@ -307,7 +308,7 @@
                                             AutomationProperties.Name="{x:Static props:Resources.Launch}"
                                             Background="{DynamicResource TertiaryBackgroundBrush}"
                                             BorderBrush="{DynamicResource SecondaryBorderBrush}"
-                                            BorderThickness="1"
+                                            BorderThickness="2"
                                             Click="LaunchButton_Click"
                                             Content="{x:Static props:Resources.Launch}" />
                                     </StackPanel>

diff --git a/src/modules/Workspaces/WorkspacesEditor/WorkspacesEditorPage.xaml b/src/modules/Workspaces/WorkspacesEditor/WorkspacesEditorPage.xaml
@@ -109,6 +109,8 @@
                                     Padding="24,6"
                                     AutomationProperties.Name="{x:Static props:Resources.Delete}"
                                     Background="{DynamicResource TertiaryBackgroundBrush}"
+                                    BorderBrush="{DynamicResource SecondaryBorderBrush}"
+                                    BorderThickness="2"
                                     Click="DeleteButtonClicked"
                                     Content="{Binding DeleteButtonContent, Mode=OneWay, UpdateSourceTrigger=PropertyChanged}"
                                     IsEnabled="True" />
@@ -338,6 +340,8 @@
                     HorizontalAlignment="Right"
                     AutomationProperties.Name="{x:Static props:Resources.Revert}"
                     Background="{DynamicResource SecondaryBackgroundBrush}"
+                    BorderBrush="{DynamicResource PrimaryBorderBrush}"
+                    BorderThickness="2"
                     Click="RevertButtonClicked"
                     Content="{x:Static props:Resources.Revert}"
                     DockPanel.Dock="Right"
@@ -350,6 +354,8 @@
                     HorizontalAlignment="Right"
                     AutomationProperties.Name="{x:Static props:Resources.LaunchEdit}"
                     Background="{DynamicResource SecondaryBackgroundBrush}"
+                    BorderBrush="{DynamicResource PrimaryBorderBrush}"
+                    BorderThickness="2"
                     Click="LaunchEditButtonClicked"
                     Content="{x:Static props:Resources.LaunchEdit}"
                     DockPanel.Dock="Right" />
@@ -402,6 +408,8 @@
                     Padding="24,0,24,0"
                     AutomationProperties.Name="{x:Static props:Resources.Cancel}"
                     Background="{DynamicResource SecondaryBackgroundBrush}"
+                    BorderBrush="{DynamicResource PrimaryBorderBrush}"
+                    BorderThickness="2"
                     Click="CancelButtonClicked"
                     Content="{x:Static props:Resources.Cancel}" />
                 <Button