[Mouse Without Borders] - refactoring "Common" classes

[mikeclayton]

Description of the new feature / enhancement

As a precursor to #34126 (Integrate Mouse Jump with Mouse Without Borders) I've spoken with @crutkas and @ethanfangg about doing some mechanical refactoring to break the large "Common" class into multiple smaller classes as general maintenance / housekeeping work.

Each "Common.*.cs" partial file will be turned into a separate static class so as to reduce the scope of the private members inside them and make it easier / safer to perform other changes (e.g. integration with Mouse Jump) at a later date.

Changes to each "Common.*.cs" file will be submitted as a separate PR.

Scenario when this would be used?

No change in functionality - this is a refactoring / maintenance change designed to make some future work easier / safer to implement.

Supporting information

No response

[crutkas]

Make it so

[crutkas]

@mikeclayton isn't this #35156 or is there more

[mikeclayton]

@crutkas - There's more PRs to come - there's about a dozen "Common.*.cs" classes and we talked about moving cautiously and doing one file at a time so as not to break anything.

I've been trying to get the Mouse Jump style work over the line in #35521 - once that's done I can spend a bit more time on Mouse Without Borders (I've got a second refactor lined up but I've not had time to go through the regression tests yet)...

[fr1g]

What's now? is #35858 related to this?

[mikeclayton]

What's now? is #35858 related to this?

This ticket is unrelated to your feature request in #35858.

[mikeclayton]

I've been trying to put together a visual for this work so the benefits can be seen more easily.

It's a long way from perfect, but here's what I've got so far...

Original Code

In short, the large blue box represents the "Common" class in Mouse Without Borders which is defined across 15 partial class files (the yellow boxes) - the "Private" members in red are visible across the entire class even though they're really private implementation details for isolated functionality in each partial class file.

The work I'm doing is to move the code from each partial class file into a separate class (e.g. the partial class code in "Common.Receiver.cs" becomes a separate "Receiver" class in "Receiver.cs"). That way the Private members are truly private to the individual classes.

The changes so far have resulted in this:

Latest Code

The blue boxes in the top right are the new Log, Thread and Receiver classes that have been extracted out of the Common partial classes. The "Private" members (red shapes) within each of these new class are now only visible within the individual classes, so it'll be easier to make changes to support the "Mouse Jump <-> Mouse Without Borders" integration work I've proposed.

Next Steps

• Part 1 - Common.Log.cs (Logger)
• Part 2 - Common.Log.cs (Thread), Common.Receiver.cs
• Part 3 - Common.MachineStuff.cs, Common.DragDrop.cs
• Part 4 - Common.Event.cs, Common.Service.cs, Common.Launch.cs, Common.Helper.cs
• Part 5 - Common.Clipboard.cs, Common.InitAndCleanup.cs
• Part 6 - Common.cs
• Part 7 - Common.Package.cs, Common.WinAPI.cs, Common.VK.cs, Common.Encryption.cs