You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Preact calls render with arguments. This is an iconic feature which allows destructuring props, state, and context in the parameter list. Currently ReSub breaks that pattern when Options.preventTryCatchInRender is falsy (which is the default).
Restoring compatibility should be as easy as forwarding the arguments list here.
Apparently I also have to manually set Options.development in order to get the TypeError thrown from destructuring undefined since my pipeline replaces the literal process.env.NODE_ENV at build time whereas you carefully test it for existence. I'll give that a shot tomorrow.
As a result my Components just rendered nothing and my coffee got cold.
Can we have this fixed?
If you want a PR it will have to wait till after the holidays.
The text was updated successfully, but these errors were encountered:
We'd be happy to look at/take in a PR for it, but none of us on the team are using Preact or have any good way to test this, so it'd be better if you found an implementation you were happy with that you could test and we could just verify that it doesn't break anything else.
Preact calls
render
with arguments. This is an iconic feature which allows destructuringprops
,state
, andcontext
in the parameter list. Currently ReSub breaks that pattern whenOptions.preventTryCatchInRender
is falsy (which is the default).Restoring compatibility should be as easy as forwarding the arguments list here.
Apparently I also have to manually set
Options.development
in order to get theTypeError
thrown from destructuringundefined
since my pipeline replaces the literalprocess.env.NODE_ENV
at build time whereas you carefully test it for existence. I'll give that a shot tomorrow.As a result my Components just rendered nothing and my coffee got cold.
Can we have this fixed?
If you want a PR it will have to wait till after the holidays.
The text was updated successfully, but these errors were encountered: