From 3e83d899d48233de5ed96ffc790c782e73a70b45 Mon Sep 17 00:00:00 2001 From: Adam Rudell Date: Tue, 13 Feb 2024 15:15:50 -0600 Subject: [PATCH] Disable Correlation for Netsh traces (#233) # Description Summary of changes: - Configure `correlation=disabled` for netsh trace to prevent issue where vm workload traffic disconnects when enabling tracing on vSwitch # Change type - [x] Bug fix (non-breaking change) - [ ] Code style update (formatting, local variables) - [ ] New Feature (non-breaking change that adds new functionality without impacting existing) - [ ] Breaking change (fix or feature that may cause functionality impact) - [ ] Other # Checklist: - [x] My code follows the style and contribution guidelines of this project. - [x] I have tested and validated my code changes. --- src/modules/SdnDiag.Common/private/Start-NetshTrace.ps1 | 8 ++++---- src/modules/SdnDiag.Common/public/Start-SdnNetshTrace.ps1 | 8 ++++---- 2 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/modules/SdnDiag.Common/private/Start-NetshTrace.ps1 b/src/modules/SdnDiag.Common/private/Start-NetshTrace.ps1 index 7f473675..2ebfdf1c 100644 --- a/src/modules/SdnDiag.Common/private/Start-NetshTrace.ps1 +++ b/src/modules/SdnDiag.Common/private/Start-NetshTrace.ps1 @@ -13,7 +13,7 @@ function Start-NetshTrace { .PARAMETER Overwrite Optional. Specifies whether this instance of the trace conversion command overwrites files that were rendered from previous trace conversions. If unspecified, the default is Yes. .PARAMETER Correlation - Optional. Specifies whether related events will be correlated and grouped together. If unspecified, the default is No. + Optional. Specifies whether related events will be correlated and grouped together. If unspecified, the default is disabled. .PARAMETER Report Optional. Specifies whether a complementing report will be generated in addition to the trace file report. If unspecified, the default is disabled. .EXAMPLE @@ -47,12 +47,12 @@ function Start-NetshTrace { [System.String]$Overwrite = 'Yes', [Parameter(Mandatory = $false)] - [ValidateSet('Enabled', 'Disabled')] + [ValidateSet('Yes', 'No', 'Disabled')] [System.String]$Report = 'Disabled', [Parameter(Mandatory = $false)] - [ValidateSet('Yes', 'No')] - [System.String]$Correlation = 'No' + [ValidateSet('Yes', 'No', 'Disabled')] + [System.String]$Correlation = 'Disabled' ) try { diff --git a/src/modules/SdnDiag.Common/public/Start-SdnNetshTrace.ps1 b/src/modules/SdnDiag.Common/public/Start-SdnNetshTrace.ps1 index c184db33..200db076 100644 --- a/src/modules/SdnDiag.Common/public/Start-SdnNetshTrace.ps1 +++ b/src/modules/SdnDiag.Common/public/Start-SdnNetshTrace.ps1 @@ -18,7 +18,7 @@ function Start-SdnNetshTrace { .PARAMETER Overwrite Optional. Specifies whether this instance of the trace conversion command overwrites files that were rendered from previous trace conversions. If unspecified, the default is Yes. .PARAMETER Correlation - Optional. Specifies whether related events will be correlated and grouped together. If unspecified, the default is No. + Optional. Specifies whether related events will be correlated and grouped together. If unspecified, the default is Disabled. .PARAMETER Report Optional. Specifies whether a complementing report will be generated in addition to the trace file report. If unspecified, the default is disabled. .EXAMPLE @@ -54,12 +54,12 @@ function Start-SdnNetshTrace { [Parameter(Mandatory = $false, ParameterSetName = 'Local')] [Parameter(Mandatory = $false, ParameterSetName = 'Remote')] - [ValidateSet('Yes', 'No')] - [System.String]$Correlation = 'No', + [ValidateSet('Yes', 'No', 'Disabled')] + [System.String]$Correlation = 'Disabled', [Parameter(Mandatory = $false, ParameterSetName = 'Local')] [Parameter(Mandatory = $false, ParameterSetName = 'Remote')] - [ValidateSet('Enabled', 'Disabled')] + [ValidateSet('Yes', 'No', 'Disabled')] [System.String]$Report = 'Disabled', [Parameter(Mandatory = $false, ParameterSetName = 'Local')]