Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix langchain error handling to avoid crash on openai>1.0.0 #2307

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

lhrotk
Copy link
Contributor

@lhrotk lhrotk commented Nov 5, 2024

Related Issues/PRs

N/A

What changes are proposed in this pull request?

The code referencing openai<1.0 classes can't run when you have openai>1.0.

How is this patch tested?

Manual tested

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.

@lhrotk lhrotk requested a review from mhamilton723 as a code owner November 5, 2024 07:13
@lhrotk
Copy link
Contributor Author

lhrotk commented Nov 5, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lhrotk
Copy link
Contributor Author

lhrotk commented Nov 5, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@lhrotk lhrotk changed the title WIP: make langchain error handling support openai>1.0 feat: make langchain error handling support openai>1.0 Nov 5, 2024
@lhrotk lhrotk changed the title feat: make langchain error handling support openai>1.0 fix: make langchain error handling support openai>1.0 Nov 5, 2024
@lhrotk lhrotk changed the title fix: make langchain error handling support openai>1.0 fix: fix langchain error handling to avoid crash on openai>1.0.0 Nov 5, 2024
@lhrotk
Copy link
Contributor Author

lhrotk commented Nov 6, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.48%. Comparing base (2758261) to head (709cb9d).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2307   +/-   ##
=======================================
  Coverage   84.48%   84.48%           
=======================================
  Files         326      326           
  Lines       16769    16769           
  Branches     1480     1480           
=======================================
  Hits        14168    14168           
  Misses       2601     2601           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mhamilton723
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mhamilton723 mhamilton723 merged commit f68c133 into microsoft:master Nov 12, 2024
65 of 68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants