Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Using nltk version 3.8.1 Azure Databricks Notebook longchain.ipynb to fix failing test #2309

Conversation

FarrukhMasud
Copy link
Contributor

@FarrukhMasud FarrukhMasud commented Nov 8, 2024

With release of new version of NLTK (3.9.1), the unit test started failing.

What changes are proposed in this pull request?

The version of NLTK is pinned to 3.8.1 in the notebook

How is this patch tested?

I have manually ran the Longchain.ipynb and validated that it is not failing anymore.

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.
  1. Find the corresponding markdown file for your new feature in website/docs/documentation folder.
    Make sure you choose the correct class estimators/transformers and namespace.
  2. Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
  3. Make sure the DocTable points to correct API link.
  4. Navigate to website folder, and run yarn run start to make sure the website renders correctly.
  5. Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
  6. Make sure the WebsiteSamplesTests job pass in the pipeline.

@FarrukhMasud FarrukhMasud changed the title Using older version of nltk chore: Using nltk version 3.8.1 for the unit test Nov 8, 2024
@FarrukhMasud FarrukhMasud changed the title chore: Using nltk version 3.8.1 for the unit test chore: Using nltk version 3.8.1 Azure Databricks test Notebook Nov 8, 2024
@FarrukhMasud FarrukhMasud changed the title chore: Using nltk version 3.8.1 Azure Databricks test Notebook fix: Using nltk version 3.8.1 Azure Databricks Notebook longchain.ipynb to fix failing test Nov 8, 2024
@FarrukhMasud FarrukhMasud marked this pull request as ready for review November 8, 2024 02:20
@FarrukhMasud
Copy link
Contributor Author

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.51%. Comparing base (feed209) to head (24a0af7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2309      +/-   ##
==========================================
- Coverage   84.57%   84.51%   -0.07%     
==========================================
  Files         326      326              
  Lines       16769    16769              
  Branches     1480     1480              
==========================================
- Hits        14183    14172      -11     
- Misses       2586     2597      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mhamilton723 mhamilton723 merged commit 2758261 into microsoft:master Nov 8, 2024
70 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants