Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Global Params #2318

Merged
merged 13 commits into from
Nov 22, 2024
Merged

Conversation

sss04
Copy link
Contributor

@sss04 sss04 commented Nov 21, 2024

Related Issues/PRs

#xxx

What changes are proposed in this pull request?

Briefly describe the changes included in this Pull Request.

How is this patch tested?

  • I have written tests (not required for typo or doc fix) and confirmed the proposed feature/bug-fix/change works.

Does this PR change any dependencies?

  • No. You can skip this section.
  • Yes. Make sure the dependencies are resolved correctly, and list changes here.

Does this PR add a new feature? If so, have you added samples on website?

  • No. You can skip this section.
  • Yes. Make sure you have added samples following below steps.
  1. Find the corresponding markdown file for your new feature in website/docs/documentation folder.
    Make sure you choose the correct class estimators/transformers and namespace.
  2. Follow the pattern in markdown file and add another section for your new API, including pyspark, scala (and .NET potentially) samples.
  3. Make sure the DocTable points to correct API link.
  4. Navigate to website folder, and run yarn run start to make sure the website renders correctly.
  5. Don't forget to add <!--pytest-codeblocks:cont--> before each python code blocks to enable auto-tests for python samples.
  6. Make sure the WebsiteSamplesTests job pass in the pipeline.

@sss04 sss04 requested a review from mhamilton723 as a code owner November 21, 2024 18:56
mhamilton723
mhamilton723 previously approved these changes Nov 22, 2024
Copy link
Collaborator

@mhamilton723 mhamilton723 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing

@mhamilton723
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.50%. Comparing base (08aab6a) to head (6e488e3).

Files with missing lines Patch % Lines
...icrosoft/azure/synapse/ml/param/GlobalParams.scala 91.66% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2318   +/-   ##
=======================================
  Coverage   84.50%   84.50%           
=======================================
  Files         326      328    +2     
  Lines       16755    16771   +16     
  Branches     1480     1506   +26     
=======================================
+ Hits        14158    14173   +15     
- Misses       2597     2598    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@sss04
Copy link
Contributor Author

sss04 commented Nov 22, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sss04 sss04 enabled auto-merge (squash) November 22, 2024 04:37
@mhamilton723 mhamilton723 merged commit 79d5b58 into microsoft:master Nov 22, 2024
65 of 67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants