chore: Making post-processing setting bit more inteligent #2321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…type. For example, if we set post-processing option as "jsonSchema", then we can infer that the post-processing type to be "json". In this changeset, I am adding this feature and also adding unit tests to validate this.
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
mhamilton723
approved these changes
Dec 2, 2024
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2321 +/- ##
==========================================
- Coverage 84.44% 84.08% -0.37%
==========================================
Files 328 328
Lines 16771 16782 +11
Branches 1506 1509 +3
==========================================
- Hits 14163 14111 -52
- Misses 2608 2671 +63 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we set post-processing options, we can infer the pos-processing type. For example, if we set post-processing option as
jsonSchema, then we can infer that the post-processing type to bejson.What changes are proposed in this pull request?
In this PR, I am adding this intelligence that when we set
post-processing-option, we can also setpost-processingif it is not already set. We can also validate that ifpost-processingis already set, then it should be the same as the inferred post-processing type. I have added unit tests to validate thisHow is this patch tested?
Unit tests validate this functionality
Does this PR change any dependencies?
Does this PR add a new feature? If so, have you added samples on website?