Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing specific subclass type definitions in StylePropertyMapReadOnly.get() return type #1863

Open
ophirbucai opened this issue Dec 22, 2024 · 0 comments
Open

Missing specific subclass type definitions in StylePropertyMapReadOnly.get() return type #1863

ophirbucai opened this issue Dec 22, 2024 · 0 comments

Comments

@ophirbucai
Copy link

Currently, StylePropertyMapReadOnly.get() returns undefined | CSSStyleValue for all CSS properties. This doesn't reflect the CSS Typed OM specification where different properties return specific subclasses like CSSUnitValue, CSSKeywordValue, and CSSTransformValue.

I have a PR ready that addresses this by narrowing down the return types based on property names.
ophirbucai added a commit to ophirbucai/TypeScript-DOM-lib-generator that referenced this issue Dec 22, 2024
@ophirbucai
(feat:lib.dom): Add specific return types for StylePropertyMapReadOnl…
17e75fc 
…y.get()

Move type definitions to overrideTypes to generate corresponding return types, include MDN references

Closes microsoft#1863
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ophirbucai