Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infer project name is case insensitive but it should #1810

Open
prupipho opened this issue May 13, 2021 · 1 comment
Open

Infer project name is case insensitive but it should #1810

prupipho opened this issue May 13, 2021 · 1 comment
Labels
bug Something is broken Wizard Wizard issue
Milestone

Comments

@prupipho
Copy link
Contributor

prupipho commented May 13, 2021

Describe the bug
Depending on the Operative System, the file system is case sensitive and allows to have files with different casing or not having them.
Function fs.existsSync doesn´t check this, so when creating a new app with the wizard in Windows, if a folder exists with the name MyApp, the suggested name provided is myApp.
Everything seems fine as it validates it correctly, but generation would error because the folder already exists.

To Reproduce
Steps to reproduce the behavior:

  1. Create a folder in the destination folder named MyApp.
  2. Open Web Template Studio (Ctrl + Shift + P: Web Template Studio) No matter if Create Web App or Create React Native App.
  3. Notice it still suggests you create an app called myApp.
  4. When you try to generate it will error.

Expected behavior
Should recommend the next available name for the app myApp1

Screenshots
It shouldn´t suggest an existing folder name.
image

Error stack

El nombre de proyecto myApp no es válido. Errores: 
Error: AlreadyExists; Validator: ExistingNamesValidator.)
@prupipho prupipho added bug Something is broken Wizard Wizard issue labels May 13, 2021
@prupipho prupipho added this to the 0.7 milestone May 13, 2021
@ghost ghost added the needs-triage For new issues that are raised to get reviewed by internal Microsoft employees label May 13, 2021
@prupipho prupipho removed the needs-triage For new issues that are raised to get reviewed by internal Microsoft employees label May 13, 2021
@sibille sibille changed the title Infer name: case insensitive Infer name is case sensitive but shouldn't May 14, 2021
@sibille sibille changed the title Infer name is case sensitive but shouldn't Infer project name is case sensitive but shouldn't May 14, 2021
@prupipho prupipho self-assigned this May 19, 2021
@prupipho prupipho added the In Progress Indicates the issue is currently being worked on label May 20, 2021
@prupipho prupipho changed the title Infer project name is case sensitive but shouldn't Infer project name is case insensitive but it should May 24, 2021
@prupipho prupipho removed the In Progress Indicates the issue is currently being worked on label May 24, 2021
@prupipho prupipho modified the milestones: 0.7, Backlog May 24, 2021
@prupipho
Copy link
Contributor Author

Investigating a bit we didn´t find an easy way to ignore the case with fs.existsSync. There´s a workaround reading the dir, but that´s not efficient and probably not worth at this stage.

@prupipho prupipho removed their assignment Jun 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken Wizard Wizard issue
Projects
None yet
Development

No branches or pull requests

1 participant