Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Samples\Content\cpp-win32\Squares\Squares.vcxproj" doesn't configure precompiled headers correctly #271

Open
mschofie opened this issue Nov 28, 2022 · 0 comments

Comments

@mschofie
Copy link
Member

"Samples\Content\cpp-win32\Squares\Squares.vcxproj" doesn't configure precompiled headers correctly, meaning that:

  1. 'pch.cpp' is compiled unnecessarily
  2. Other '.cpp' files don't benefit from precompiled headers.

Only the Debug|Win32 configuration actually specifies any precompiled header settings, and they appear to be wrong - it sets the PrecompiledHeader metadata to Create for all ClCompile items, it should be set to Use by default and Create for pch.cpp.

Without precompiled headers (i.e. as the project is currently defined) the build takes ~26 seconds on my machine. Opt-ing in to precompiled headers takes it to ~11 seconds for a full build, and incremental builds would also benefit.

mschofie added a commit to mschofie/WindowsAppSDK-Samples that referenced this issue Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant