Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: contradiction in docs about single instance apps #4847

Open
fabianoriccardi opened this issue Nov 4, 2024 · 3 comments
Open

Docs: contradiction in docs about single instance apps #4847

fabianoriccardi opened this issue Nov 4, 2024 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@fabianoriccardi
Copy link

Describe the bug

There is a contradiction info about the default behavior of app instancing. I think in WinUI / Windows App SDK the correct is that they are multi-instance by default.

Steps to reproduce the bug

The links:

WinUI apps are single-instanced by default

WinUI apps are multi-instanced by default.

Expected behavior

No response

Screenshots

No response

NuGet package version

None

Packaging type

No response

Windows version

No response

IDE

No response

Additional context

No response

@alvinashcraft
Copy link

Hi @fabianoriccardi. Thanks for reporting this inconsistency. I'll verify the behavior again, but in my testing of WinUI apps out of the box, they are multi-instanced. I'll verify and fix this issue in the docs and will follow up when the changes are merged.

@RDMacLachlan RDMacLachlan added documentation Improvements or additions to documentation and removed needs-triage labels Nov 7, 2024
@alvinashcraft
Copy link

The docs have been updated so the first page you've linked says that WinUI apps are multi-instanced by default. I have one minor tweak to the wording from a second PR that hasn't published yet, but it should be live in 10-15 minutes.

@fabianoriccardi
Copy link
Author

Great!

WinUI apps are multi-instanced by default but have the ability to become single-instanced by deciding at launch-time whether to create a new instance or activate an existing instance instead.

I don't remember the exact wording of this whole sentence, but now, for sure, reflects what exactly happens: at the core the app, in the core, is always a multi-instance app, but the second instance can quit itself and reactivate the already existing instance. As a developer feels like a hack, but from user perspective it works perfectly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants