Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P2 FEATURE] Add error string when search doesn't find any results #12

Closed
gregwoo-microsoft opened this issue Nov 19, 2024 · 6 comments
Closed

Comments

@gregwoo-microsoft
Copy link
Contributor

Image

There should be an error message when the search query doesn't yield any results

@gregwoo-microsoft gregwoo-microsoft changed the title [FEATURE] Add error string when search doesn't find any results [P2 FEATURE] Add error string when search doesn't find any results Nov 19, 2024
@Pinguin2001
Copy link
Contributor

I can work on this, is a ContentDialog fine, or should a InfoBar be displayed instead?

@nmetulev
Copy link
Member

Thanks @Pinguin2001. @niels9001, what do you think about how to display this error message?

@niels9001
Copy link
Contributor

A TextBlock with message in the results pane would suffice?

@Pinguin2001
Copy link
Contributor

Id say either a simple TextBlock or InfoBar

@pealmasa
Copy link

Not sure if this was understood, but it seems the issue is more "deep" than simply a model not found in search and add a text block or infobar.

See: #75

@niels9001
Copy link
Contributor

Closed by #116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants