Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] GenAIModel.cs should not be directly referenced in non-GenAI samples. #197

Closed
azchohfi opened this issue Feb 12, 2025 · 0 comments · Fixed by #220
Closed

[BUG] GenAIModel.cs should not be directly referenced in non-GenAI samples. #197

azchohfi opened this issue Feb 12, 2025 · 0 comments · Fixed by #220
Assignees
Labels
🐛bug Something isn't working

Comments

@azchohfi
Copy link
Contributor

Describe the bug
Right now, many samples reference GenAIModel.cs, even though we don't specifically need that class.
That is mostly because of some constants that exist there, that should be abstracted into the metadata of IChatClient.
That also forces PhiSilica samples to reference OnnxRuntimeGenAI nugets, which should not be the case at all.

To Reproduce
Steps to reproduce the behavior:

  1. Export, for example, the Generate Sample, selecting the PhiSilica API

Expected behavior
It should not reference GenAIModel.cs, and it should not reference OnnxRuntimeGenAI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant