Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan file support #205

Merged
merged 114 commits into from
May 25, 2024
Merged

Plan file support #205

merged 114 commits into from
May 25, 2024

Conversation

chhwang
Copy link
Contributor

@chhwang chhwang commented Jan 16, 2024

  • Completely separate model definition from implementation
  • Plan file details full implementation
  • Models and plans are serialized into JSON
  • Deeper integration with MSCCL++
  • A few bug fixes

@chhwang chhwang marked this pull request as ready for review March 21, 2024 22:02
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 89.53810% with 265 lines in your changes are missing coverage. Please review.

Project coverage is 90.50%. Comparing base (e476238) to head (2e45981).

Files Patch % Lines
ark/model/model_graph_impl.cpp 84.72% 44 Missing ⚠️
ark/api/executor.cpp 93.43% 29 Missing ⚠️
ark/ops/ops_matmul.cpp 81.29% 26 Missing ⚠️
ark/api/tensor.cpp 41.37% 17 Missing ⚠️
ark/codegen.cpp 93.98% 13 Missing ⚠️
ark/model/model_op_arg.cpp 71.11% 13 Missing ⚠️
ark/model/model_offset.cpp 50.00% 12 Missing ⚠️
ark/model/model_op.cpp 90.55% 12 Missing ⚠️
ark/ops/ops_communication.cpp 89.71% 11 Missing ⚠️
ark/api/dims.cpp 89.79% 10 Missing ⚠️
... and 18 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
+ Coverage   86.95%   90.50%   +3.54%     
==========================================
  Files          85      103      +18     
  Lines        5843     3958    -1885     
==========================================
- Hits         5081     3582    -1499     
+ Misses        762      376     -386     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chhwang chhwang force-pushed the chhwang/schedule branch 5 times, most recently from 5e64787 to 473288c Compare April 5, 2024 05:36
@chhwang chhwang force-pushed the chhwang/schedule branch 3 times, most recently from 94d33b1 to 9c26e9a Compare April 18, 2024 07:24
@chhwang chhwang force-pushed the chhwang/schedule branch 3 times, most recently from 432d777 to 2a5a4a7 Compare April 26, 2024 07:14
Copy link
Contributor

@Binyang2014 Binyang2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me. Just have several questions. Will finish the review soon

examples/llama/model_test.py Show resolved Hide resolved
ark/gpu/gpu_kernel_test.cpp Outdated Show resolved Hide resolved
ark/model/model_buffer.cpp Show resolved Hide resolved
ark/api/executor.cpp Show resolved Hide resolved
ark/api/executor.cpp Show resolved Hide resolved
ark/codegen.cpp Show resolved Hide resolved
ark/codegen.cpp Show resolved Hide resolved
ark/codegen.cpp Outdated Show resolved Hide resolved
ark/model/model_node.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@Binyang2014 Binyang2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't review all files. Since most of op related code are similar, just reviewed some of them

ark/include/kernels/common/unit_op.h Outdated Show resolved Hide resolved
@chhwang chhwang merged commit e3cc6e3 into main May 25, 2024
9 checks passed
@chhwang chhwang deleted the chhwang/schedule branch May 25, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants