Enhance the behavior of the method that loads llm_config and add new tests #3277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umermansoor
commented
Aug 2, 2024
| @@ -1413,7 +1447,7 @@ def test_http_client(): | |||
|
|
|||
| def test_adding_duplicate_function_warning(): | |||
|
|
|||
| config_base = [{"base_url": "http://0.0.0.0:8000", "api_key": "NULL"}] | |||
| config_base = [{"base_url": "http://0.0.0.0:8000", "api_key": "NULL", "model": "na"}] | |||
There was a problem hiding this comment.
I added model here because it seems like a required field and shouldn't be omitted. If that's not the case (which I doubt), lmk and we can make it optional.
umermansoor
changed the title
|
@thinkall Can I get a review on this? |
|
Could you create the PR from a branch in the upstream repo so that we can run the openai tests? |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The current _validate_llm_config method contains redundancy and lacks comprehensive issue checks (for example, I was passing a
stringfortagsand it didn't complain and required 30 minutes to debugging to figure out what the issue was). This improved version addresses these problems and includes 2 news tests.Related issue number
Checks