[.NET] Add happy path test for in-memory agent && Simplify HelloAgent example && some clean-up in extension APIs #4227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LittleLittleCloud
changed the title
dotnet/src/Microsoft.AutoGen/Agents/Services/AgentWorkerHostingExtensions.cs
Show resolved
Hide resolved
rysweet
requested changes
Nov 16, 2024
There was a problem hiding this comment.
I like this. did you try this with grpc as well to make sure it still works? it conflicts with some changes Reuben was proposing that used the .Web SDK instead of .SDK. the changes to HelloAgents I am less thrilled about mainly because I liked how the previous version did everything in one shot. maybe we could have both?
I haven't had time to try and run this yet and make sure it still also works with gprc. If you have done that let me know and I'll go ahead and merge.
What this PR does shouldn't affect the behavior of w/ grpc so I think it should still work. I can verify the case If you point me to a grpc example to try.
It indeed have both. The |
rysweet
approved these changes
Nov 18, 2024
dotnet/src/Microsoft.AutoGen/Extensions/ServiceDefaults/Extensions.cs
Outdated
Show resolved
Hide resolved
rysweet
pushed a commit
that referenced
this pull request
Nov 18, 2024
… example && some clean-up in extension APIs (#4227) * add happy path test * remove unnecessary namespace * fix build error * Update AgentBaseTests.cs * revert changes ---------
rysweet
added a commit
that referenced
this pull request
Nov 19, 2024
* add subscription response * fix send subscription response * add register agent type response * adding a test * working on shaping up a test * appsettins update for backend * another appsettings * fixup aspire hosting * enable AGENT_HOST var from aspire * add SendMessageAsync * remove broken test * test compiles and runs but is not (yet) correct * subscriptions grain wireup. * temp assert true. * remove DI for SubscriptionGrain * add xlang python code * add subscription response * rebond * Update to .NET 9.0 * Fix Backend project SDK * Package updates * get RegisterAgentTypeRequest working * fix exceptions * add error handling for requests * whoops * send cloud event message type * processing cloudevents * trying tosend proto data - doesn't work * trying to pack proto_data * fix (#4238) * pack the Message from agents_events * format - not sure why these? * format * cleanup, error handling, xlang sample publishes messages that can be heard by .NET and vice versa * format * sdk version * sdk vers * net8 * back to net8 * remove netstandard2 * fix used * remove unused * more cleanup * remove unneeded package * I'm terrible at writing tests * deserialize the cloud events and sent them as events * comment * cleanup * await * Delete dotnet/samples/Hello/Backend/Backend.csproj unneeded change * whoops * merge main python back into here * revert back to local * revert some of the helloAgents changes. * [.NET] Add happy path test for in-memory agent && Simplify HelloAgent example && some clean-up in extension APIs (#4227) * add happy path test * remove unnecessary namespace * fix build error * Update AgentBaseTests.cs * revert changes --------- * fix busted merge from main * addressing review comments * make internal * case sensitive rename step 1 * case sensitive rename step 2 * remove! --------- Co-authored-by: Peter Chang <[email protected]> Co-authored-by: Reuben Bond <[email protected]> Co-authored-by: Eric Zhu <[email protected]> Co-authored-by: Xiaoyun Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR does the following work
WebApplicationBuilder->IHostApplicationBuilder)Related issue number
Checks