Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REGRESSION]: DeleteFiles fails with no such file or directory with filename containing emoji #19395

Closed
4 of 7 tasks
mlaurencin opened this issue Dec 19, 2023 · 3 comments
Closed
4 of 7 tasks
Assignees
Labels
Area: Artifacts bug regression This used to work, but a change in the service/tasks broke it.

Comments

@mlaurencin
Copy link

New issue checklist

Task name

DeleteFiles

Breaking task version

1.231.1

Last working task version

1.231.0

Regression Description

Expected: DeleteFiles to scan through all files without issue
Actual: DeleteFiles error when trying to parse one specific file within this Node directory. It states that this file does not exist. (We noted that this was the first file that contained emojis).

Environment type (Please select at least one enviroment where you face this issue)

  • Self-Hosted
  • Microsoft Hosted
  • VMSS Pool
  • Container

Azure DevOps Server type

dev.azure.com (formerly visualstudio.com)

Azure DevOps Server Version (if applicable)

No response

Operation system

Windows 2019

Relevant log output

2023-12-15T22:49:49.6680312Z ##[section]Starting: DeleteFiles
2023-12-15T22:49:49.6780409Z ==============================================================================
2023-12-15T22:49:49.6780526Z Task         : Delete files
2023-12-15T22:49:49.6780582Z Description  : Delete folders, or files matching a pattern
2023-12-15T22:49:49.6780674Z Version      : 1.231.1
2023-12-15T22:49:49.6780726Z Author       : Microsoft Corporation
2023-12-15T22:49:49.6780789Z Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/delete-files
2023-12-15T22:49:49.6780897Z ==============================================================================
2023-12-15T22:50:16.9547428Z ##[error]Unhandled: Failed find: ENOENT: no such file or directory, lstat 'D:\a\_work\1\b\src\third_party\electron_node\deps\v8\test\message\unicode-filename-🎅🎄.js'
2023-12-15T22:50:16.9550552Z ##[error]Error: Failed find: ENOENT: no such file or directory, lstat 'D:\a\_work\1\b\src\third_party\electron_node\deps\v8\test\message\unicode-filename-🎅🎄.js'
    at Object.find (D:\a\_work\_tasks\DeleteFiles_b7e8b412-0437-4065-9371-edc5881de25b\1.231.1\node_modules\azure-pipelines-task-lib\task.js:1000:15)
    at D:\a\_work\_tasks\DeleteFiles_b7e8b412-0437-4065-9371-edc5881de25b\1.231.1\deletefiles.js:29:25
    at Object.<anonymous> (D:\a\_work\_tasks\DeleteFiles_b7e8b412-0437-4065-9371-edc5881de25b\1.231.1\deletefiles.js:101:3)
    at Module._compile (node:internal/modules/cjs/loader:1241:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1295:10)
    at Module.load (node:internal/modules/cjs/loader:1091:32)
    at Module._load (node:internal/modules/cjs/loader:938:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:83:12)
    at node:internal/main/run_main_module:23:47
2023-12-15T22:50:16.9860863Z ##[section]Finishing: DeleteFiles

Full task logs with system.debug enabled

No response

Repro steps

# Some files and directories should not be published.
    - task: DeleteFiles@1
      inputs:
        SourceFolder: ${{ parameters._workingDirectory }}
        Contents: |
          **/.azure-devops
          **/.git
          **/.npmrc
          **/.sdl
          src/microsoft/README.md
          src/third_party/depot_tools/win_toolchain/vs_files
@mlaurencin mlaurencin added bug regression This used to work, but a change in the service/tasks broke it. labels Dec 19, 2023
@ivanduplenskikh
Copy link
Contributor

@mlaurencin, thanks for reporting!
The error is reproduced due to an issue in node itself. As soon as we are able to update the dependency to include this fix, I will notify you.

@ivanduplenskikh
Copy link
Contributor

@mlaurencin DeleteFilesV1 v1.235.0 is already available.
Could you confirm the fix?

@ivanduplenskikh
Copy link
Contributor

I'm closing this issue for now.
Feel free to reopen if it's still relevant for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Artifacts bug regression This used to work, but a change in the service/tasks broke it.
Projects
None yet
Development

No branches or pull requests

3 participants