Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfigurationBotFrameworkAuthentication errors when initialized with process.env #4853

Open
rido-min opened this issue Feb 6, 2025 · 1 comment · May be fixed by #4857
Open

ConfigurationBotFrameworkAuthentication errors when initialized with process.env #4853

rido-min opened this issue Feb 6, 2025 · 1 comment · May be fixed by #4857
Assignees
@ceciliaavila
Labels
bug Indicates an unexpected problem or an unintended behavior.

Comments

@rido-min
Copy link
Member

rido-min commented Feb 6, 2025 •
edited
Loading

Versions

"botbuilder": "~4.23.0",

Describe the bug

When using

new ConfigurationBotFrameworkAuthentication(process.env) like in this sample

https://github.com/microsoft/BotBuilder-Samples/blob/6952b9e548038d58e3c8cd607acaa72dcf7648a0/samples/javascript_nodejs/45.state-management/index.js#L35

I got errors from VSCode when enabling ts-check, or when trying to use TypeScript.

Type 'ProcessEnv' has no properties in common with type '{ BotOpenIdMetadata?: string | undefined; ChannelService?: string | undefined; OAuthApiEndpoint?: string | undefined; CertificateThumbprint?: string | undefined; CertificatePrivateKey?: string | undefined; ... 9 more ...; CallerId?: string | undefined; }'.

To Reproduce

Steps to reproduce the behavior:

  1. Go to BotBuilder-Samples/samples/javascript_nodejs/45.state-management/index.js
  2. Add ts-check to index.js

Expected behavior

Provided declaration types should match expected usage
@rido-min rido-min added bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. labels Feb 6, 2025
@rido-min
Copy link
Member Author

rido-min commented Feb 6, 2025

this also reproes with 4.23.2-rc2

@tracyboehrer tracyboehrer removed the needs-triage The issue has just been created and it has not been reviewed by the team. label Feb 6, 2025
@sw-joelmut sw-joelmut linked a pull request Feb 11, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ceciliaavila ceciliaavila

Labels
bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Milestone
No milestone
3 participants
@tracyboehrer @rido-min @ceciliaavila