Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Tsubo (坪), a Japanese unit of floorspace for Japan and Taiwan #2100

Open
TobySkarting opened this issue Dec 21, 2023 · 0 comments · May be fixed by #2101
Open

Adding support for Tsubo (坪), a Japanese unit of floorspace for Japan and Taiwan #2100

TobySkarting opened this issue Dec 21, 2023 · 0 comments · May be fixed by #2101

Comments

@TobySkarting
Copy link

Problem Statement
The Microsoft Calculator currently lacks support for the Tsubo (坪), a traditional Japanese unit of area and floorspace that is also widely used in Taiwan. The absence of this unit in the Calculator app creates an inconvenience for users in these regions who commonly use Tsubo in real estate and construction contexts. By integrating Tsubo, the app can cater to a broader audience and address a specific regional need.

Evidence or User Insights
According to Wikipedia article on , the Tsubo is a unit born in Japan but was also used in Korea and Taiwan during Japanese rule. In Taiwan, despite the government's declaration in 1945 to switch to square meters, Tsubo is still widely used in civilian contexts. This historical and ongoing usage in these regions provides a strong case for its inclusion in the Calculator app to meet user expectations and requirements.

Proposal
The proposal is to integrate Tsubo as a unit of measurement for area and floorspace in the Microsoft Calculator app. This integration will enable users in Japan and Taiwan, and those familiar with the unit, to perform conversions directly within the app, enhancing its utility and relevance in these markets.

Goals
User can convert between Tsubo and other units of area (such as square meters, square feet, etc.) within the Calculator app.

Non-Goals

  1. Overhaul of the existing measurement conversion system in the app.
  2. Integration of every traditional unit of measurement from every culture, as the focus is specifically on Tsubo due to its significant usage in specific regions.

Low-Fidelity Concept
As the equivalent unit conversion has been implemented for Korean regions by #382, and the translations for Taiwan

<data name="UnitAbbreviation_Pyeong" xml:space="preserve">
<value>坪</value>
<comment>An abbreviation for a measurement unit of area.</comment>
</data>
<data name="UnitName_Pyeong" xml:space="preserve">
<value>坪</value>
<comment>A measurement unit for area.</comment>
</data>

and Japan
<data name="UnitAbbreviation_Pyeong" xml:space="preserve">
<value>坪</value>
<comment>An abbreviation for a measurement unit of area.</comment>
</data>
<data name="UnitName_Pyeong" xml:space="preserve">
<value>坪</value>
<comment>A measurement unit for area.</comment>
</data>

were translated correctly, one can simply implement this feature by adding these two regions to the supported region list.

bool usePyeong = m_currentRegionCode == L"JP" || m_currentRegionCode == L"TW" || m_currentRegionCode == L"KP" || m_currentRegionCode == L"KR";

A dev build run in TW region would look like this:
image

Requested Assignment
If possible, I would like to implement this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant