You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Thanks so much for filing an issue or feature request! Please fill out the following (wherever relevant):
Description
The source code for the sync method takes 4 arguments (syncCallback, syncOptions, downloadProgress and syncErrback), but the documentation and the typescript definition file only describe the first 3 arguments. This causes linting issues when transpiling the code and keeps developers from being able to correctly implement the error callback function. I expect to have the documentation and typescript definition to match the implementation of the code.
Reproduction
Source:
codePush.js:
CodePush.prototype.sync = function (syncCallback, syncOptions, downloadProgress, syncErrback)
Thanks so much for filing an issue or feature request! Please fill out the following (wherever relevant):
Description
The source code for the sync method takes 4 arguments (syncCallback, syncOptions, downloadProgress and syncErrback), but the documentation and the typescript definition file only describe the first 3 arguments. This causes linting issues when transpiling the code and keeps developers from being able to correctly implement the error callback function. I expect to have the documentation and typescript definition to match the implementation of the code.
Reproduction
Source:
codePush.js:
CodePush.prototype.sync = function (syncCallback, syncOptions, downloadProgress, syncErrback)
codePush.d.ts:
sync(syncCallback?: SuccessCallback, syncOptions?: SyncOptions, downloadProgress?: SuccessCallback): void;
Additional Information
The text was updated successfully, but these errors were encountered: