Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The filter passed to _PurgeAllInstancesAsync(PurgeInstancesFilter filter, CancellationToken cancellation)_ on the DurableTaskClient, is not used, instead a new instance is created #288

Closed
JohanKlijn opened this issue Apr 18, 2024 · 1 comment
Labels

Comments

@JohanKlijn
Copy link
Contributor

The filter passed to PurgeAllInstancesAsync(PurgeInstancesFilter filter, CancellationToken cancellation) on the DurableTaskClient, is not used, instead a new instance is created, see https://github.com/microsoft/durabletask-dotnet/blob/main/src/Client/Core/DurableTaskClient.cs#L379C2-L381C88.

Code in DurableTaskClient:

    public virtual Task<PurgeResult> PurgeAllInstancesAsync(PurgeInstancesFilter filter, CancellationToken cancellation)
        => this.PurgeAllInstancesAsync(new PurgeInstancesFilter(), null, cancellation);

Did not investigate this, but it could be the cause of #282

@jviau
Copy link
Member

jviau commented Apr 25, 2024

Resolved by #289

@jviau jviau closed this as completed Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants