Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Niganesh/validate open id4 vci network responses #73

Merged
merged 64 commits into from
Mar 18, 2024

Conversation

nithyaganeshng
Copy link
Contributor

@nithyaganeshng nithyaganeshng commented Mar 13, 2024

Perform validations on the Credential Metadata and Credential Offer fetched. Validate the fields on those objects and make sure they match the expected values.

Validation:
Added unit tests to verify the changes.

Type of change:

  • Feature work
  • Bug fix
  • Documentation
  • Engineering change
  • Test
  • Logging/Telemetry

Risk:

  • High – Errors could cause MAJOR regression of many scenarios. (Example: new large features or high level infrastructure changes)
  • Medium – Errors could cause regression of 1 or more scenarios. (Example: somewhat complex bug fixes, small new features)
  • Small – No issues are expected. (Example: Very small bug fixes, string changes, or configuration settings changes)

Work Item links:
Please include here links for this work item, or deferred work, or related work. E.g. if the refactoring is too big to fit in this PR, or the localized strings need to be updated later, please link the TODO work items here.

Documentation Links:
Please include here links to any related background documentation for this PR.

Nithya Ganesh and others added 30 commits May 24, 2023 16:41
@nithyaganeshng nithyaganeshng marked this pull request as ready for review March 16, 2024 03:58
@nithyaganeshng nithyaganeshng merged commit fe56099 into dev Mar 18, 2024
2 checks passed
@nithyaganeshng nithyaganeshng deleted the niganesh/validate-OpenId4Vci-network-responses branch March 18, 2024 20:39
logangirvin added a commit that referenced this pull request Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants