-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Niganesh/validate open id4 vci network responses #73
Merged
nithyaganeshng
merged 64 commits into
dev
from
niganesh/validate-OpenId4Vci-network-responses
Mar 18, 2024
Merged
Niganesh/validate open id4 vci network responses #73
nithyaganeshng
merged 64 commits into
dev
from
niganesh/validate-OpenId4Vci-network-responses
Mar 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate-OpenId4Vci-network-responses
symorton
requested changes
Mar 18, 2024
...tlibrary/src/main/java/com/microsoft/walletlibrary/mappings/LinkedDomainsServiceExtension.kt
Show resolved
Hide resolved
...rosoft/walletlibrary/networking/entities/openid4vci/credentialmetadata/CredentialMetadata.kt
Show resolved
Hide resolved
...rosoft/walletlibrary/networking/entities/openid4vci/credentialmetadata/CredentialMetadata.kt
Outdated
Show resolved
Hide resolved
...rary/src/main/java/com/microsoft/walletlibrary/requests/handlers/OpenId4VCIRequestHandler.kt
Show resolved
Hide resolved
...rary/src/main/java/com/microsoft/walletlibrary/requests/handlers/OpenId4VCIRequestHandler.kt
Outdated
Show resolved
Hide resolved
...brary/src/main/java/com/microsoft/walletlibrary/requests/handlers/SignedMetadataProcessor.kt
Outdated
Show resolved
Hide resolved
...brary/src/main/java/com/microsoft/walletlibrary/requests/handlers/SignedMetadataProcessor.kt
Outdated
Show resolved
Hide resolved
...brary/src/main/java/com/microsoft/walletlibrary/requests/handlers/SignedMetadataProcessor.kt
Outdated
Show resolved
Hide resolved
...st/java/com/microsoft/walletlibrary/networking/entities/openid4vci/CredentialMetadataTest.kt
Outdated
Show resolved
Hide resolved
...st/java/com/microsoft/walletlibrary/networking/entities/openid4vci/CredentialMetadataTest.kt
Outdated
Show resolved
Hide resolved
symorton
approved these changes
Mar 18, 2024
nithyaganeshng
deleted the
niganesh/validate-OpenId4Vci-network-responses
branch
March 18, 2024 20:39
logangirvin
added a commit
that referenced
this pull request
Apr 5, 2024
Co-authored-by: Nithya Ganesh <[email protected]> Co-authored-by: Logan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perform validations on the Credential Metadata and Credential Offer fetched. Validate the fields on those objects and make sure they match the expected values.
Validation:
Added unit tests to verify the changes.
Type of change:
Risk:
Work Item links:
Please include here links for this work item, or deferred work, or related work. E.g. if the refactoring is too big to fit in this PR, or the localized strings need to be updated later, please link the TODO work items here.
Documentation Links:
Please include here links to any related background documentation for this PR.