Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

released version should be dropped in zip format Etl2Pcapng.zip #61

Closed
walter-1 opened this issue Nov 21, 2022 · 10 comments
Closed

released version should be dropped in zip format Etl2Pcapng.zip #61

walter-1 opened this issue Nov 21, 2022 · 10 comments

Comments

@walter-1
Copy link

The Explorer plugin from James Kehr at https://github.com/microsoft/Convert-Etl2Pcapng expects to see a .zip file on the release server (https://github.com/microsoft/etl2pcapng/releases)

Can you please post the compressed Etl2Pcapng.zip there again? Thanks.

Reason: all engineers having installed the Explorer plugin are failing to convert ETL files to Wireshark pcap format after version 1.9.0 had been released.

@maolson-msft
Copy link
Contributor

Thanks for the report Walter.

@JamesKehr I switched from the current zipfile-with-two-archs drop format to just dropping the 64-bit binary. How inconvenient is it for your wrapper to deal with this change?

@JamesKehr
Copy link

It won't be a problem. I just need to earmark a couple of hours to update the code.

@maolson-msft
Copy link
Contributor

Good to hear! I'll leave this Issue open until then.

@JamesKehr
Copy link

JamesKehr commented Nov 22, 2022

@maolson-msft, the updated module has been published to the PowerShell Gallery. Version 2022-11-22 supports the new x64 binary download.

https://www.powershellgallery.com/packages/Convert-Etl2Pcapng/2022.11.22

https://github.com/microsoft/Convert-Etl2Pcapng

Please let me know if you run into any issues.

@maolson-msft
Copy link
Contributor

@walter-1, how's it look?

@walter-1
Copy link
Author

Great! appreciate all combined efforts and agree resolving this issue.
FYI: Update-Module did the trick for me to make the installed plug-in work again! Thanks James!

PS C:\TSSv2> Update-Module

Untrusted repository
You are installing the modules from an untrusted repository. If you trust this repository, change its InstallationPolicy value by running the Set-PSRepository cmdlet. Are you sure you want to install the modules from 'PSGallery'?
[Y] Yes  [A] Yes to All  [N] No  [L] No to All  [S] Suspend  [?] Help (default is "N"): A

@dgcom
Copy link

dgcom commented Nov 23, 2022

I would vote to keep zip file - many places have policy to prevent .exe download, but allow .zip files.

@ViDou83
Copy link
Contributor

ViDou83 commented Nov 23, 2022

It works for me as well, and what a surprise to see the speed of trace conversion! That will drop my coffee consumption for sure :)

@nibanks
Copy link
Member

nibanks commented Nov 23, 2022

I propose the following instead of including the zip: #63. This will make it very trivial to install on Windows: winget install etl2pcapng.

@dgcom
Copy link

dgcom commented Nov 23, 2022

Installing with package manager is not helping people, who cannot download executables from the web. Places which prohibit that won't allow unrestricted package managers either.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants