Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embed File Info and Version #65

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Embed File Info and Version #65

wants to merge 1 commit into from

Conversation

nibanks
Copy link
Member

@nibanks nibanks commented Nov 23, 2022 •
edited
Loading

image

@nibanks nibanks added the enhancement New feature or request label Nov 23, 2022
@maolson-msft
Copy link
Contributor

This PR adds an obscure rc file and moves a point of maintenance (the value of VERSION) to a harder-to-notice place. What do we get in return?

@nibanks
Copy link
Member Author

nibanks commented Nov 23, 2022

This PR adds an obscure rc file and moves a point of maintenance (the value of VERSION) to a harder-to-notice place. What do we get in return?

The exe has the file info for version, description and copyright.

@maolson-msft
Copy link
Contributor

Sure, but why is that more useful than simply printing the version? Is it required by the proposed package manager work?

@nibanks
Copy link
Member Author

nibanks commented Nov 23, 2022

I don't think anything requires it, but the file info is a nice to have feature IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nibanks @maolson-msft