Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Investigate / and fix the way that we calculate available memory in our tasks #3585

Open
kananb opened this issue Oct 19, 2023 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@kananb
Copy link
Contributor

kananb commented Oct 19, 2023

I have a suspicion that we aren't counting swap space on Linux nodes when calculating available memory.

I think it's worth checking both the Windows and Linux memory calculations to ensure that they are counting all available memory instead of just physical memory.

Starting the Linux Investigation

For linux, we're using /proc/meminfo to learn about memory availability. But, based on this page about that file we might want to consider swap space and virtual memory rather than just "general memory".

Starting the Windows Investigation

It's not entirely clear to me based on the Win32 docs on the PERFORMANCE_INFORMATION struct that the value we're calculating with accounts for all free memory (swap and virtual included). Another source might be needed (or just consultation with someone who knows more of the terminology).

AB#168356

@kananb kananb added the bug Something isn't working label Oct 19, 2023
@kananb kananb self-assigned this Oct 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants