Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove /dev/mem usage when reading vtl2 parameters and instead pass info via dt or reconstruct #263

Open
chris-oo opened this issue Nov 7, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@chris-oo
Copy link
Member

chris-oo commented Nov 7, 2024

We shouldn't use /dev/mem to read data, and instead should use device tree and reconstruct what we need.

This is easy for the measured information, but harder for the SLIT/PPTT. However, we should be able to reconstruct this information from device tree.

@smalis-msft smalis-msft added the enhancement New feature or request label Nov 7, 2024
chris-oo added a commit that referenced this issue Nov 8, 2024
…te (#265)

Add a magic header to measured information that should be loaded by the
host. Additionally, zero out the VTL2 boot data range, to validate that
on servicing operations, the host actually deposits new data.

This fixes the issue on ARM64 where this data was not actually written.
Thus, on a cold boot where memory is zeroed, the correct value of vtom =
0 was read, but during a servicing operation because this memory was not
part of the launch context, the value could be garbage and cause
failures later during initialization.

In the future, we should just have the bootloader parse the information
here, but getting the SLIT and PPTT info reconstructed is a bit
trickier. Tracked by #263

---------

Co-authored-by: Brian Perkins <[email protected]>
@chris-oo
Copy link
Member Author

Unfortunately this gets a bit harder with the reserved region #304 . I don't know if we can easily remove some of these binary-only info, since packing them in device tree seems like the wrong thing to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants